Bug 93211

Summary:

[V8] Replace v8::Handle<v8::Value>() in bindings/v8/* with v8Undefined()

Product:

WebKit

Reporter:

Kentaro Hara <haraken>

Component:

WebCore JavaScript

Assignee:

Kentaro Hara <haraken>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, japhet, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

93095

Attachments:

Description	Flags
Patch	webkit.review.bot: commit-queue-
patch for landing	haraken: commit-queue-
patch for landing	none

Kentaro Hara

Reported 2012-08-05 17:19:06 PDT

We should use v8Undefined() everywhere in V8 bindings. Replacing v8::Local<v8::Value>() etc with v8Undefined() can cause build errors due to type conversion mismatch. I'll do the replacement in follow-up patches.

Attachments
Patch (45.16 KB, patch) 2012-08-05 17:21 PDT, Kentaro Hara	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
patch for landing (45.76 KB, patch) 2012-08-07 17:35 PDT, Kentaro Hara	haraken: commit-queue-	Details Formatted Diff Diff
patch for landing (11.20 KB, patch) 2012-08-07 17:47 PDT, Kentaro Hara	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Kentaro Hara

Comment 1 2012-08-05 17:21:03 PDT

Created attachment 156576 [details] Patch

Eric Seidel (no email)

Comment 2 2012-08-07 15:22:51 PDT

Comment on attachment 156576 [details] Patch LGTM.

WebKit Review Bot

Comment 3 2012-08-07 15:59:26 PDT

Comment on attachment 156576 [details] Patch Rejecting attachment 156576 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: WebCore/bindings/v8/custom/V8NamedNodeMapCustom.cpp patching file Source/WebCore/bindings/v8/custom/V8NodeListCustom.cpp patching file Source/WebCore/bindings/v8/custom/V8SVGLengthCustom.cpp patching file Source/WebCore/bindings/v8/custom/V8StorageCustom.cpp patching file Source/WebCore/bindings/v8/custom/V8StyleSheetListCustom.cpp Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13448745

Kentaro Hara

Comment 4 2012-08-07 17:35:48 PDT

Created attachment 157055 [details] patch for landing

Kentaro Hara

Comment 5 2012-08-07 17:47:10 PDT

Created attachment 157058 [details] patch for landing

WebKit Review Bot

Comment 6 2012-08-07 21:38:35 PDT

Comment on attachment 157058 [details] patch for landing Clearing flags on attachment: 157058 Committed r124981: <http://trac.webkit.org/changeset/124981>

Note You need to log in before you can comment on or make changes to this bug.