Bug 93173

Summary: Stop exposing window.layoutTestController in layout tests in favor of window.testRunner
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: New BugsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, dglazkov, tkent, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 88210, 93176, 93184    
Bug Blocks:    
Attachments:
Description Flags
Patch
abarth: review+, webkit.review.bot: commit-queue-
Archive of layout-test-results from gce-cr-linux-01 none

Ryosuke Niwa
Reported 2012-08-03 19:34:55 PDT
Stop exposing window.layoutTestController in layout tests in favor of window.testRunner
Attachments
Patch (9.95 KB, patch)
2012-08-03 19:43 PDT, Ryosuke Niwa 		abarth: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from gce-cr-linux-01 (413.95 KB, application/zip)
2012-08-03 22:06 PDT, WebKit Review Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-08-03 19:43:13 PDT
Created attachment 156506 [details] Patch
WebKit Review Bot
Comment 2 2012-08-03 22:06:04 PDT
Comment on attachment 156506 [details] Patch Attachment 156506 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13439024 New failing tests: http/tests/misc/char-encoding-in-hidden-charset-field-with-Big5.html http/tests/misc/char-encoding-in-hidden-charset-field-with-one-field.html http/tests/misc/char-encoding-in-hidden-charset-field-with-ISO-2022-JP.html fast/encoding/char-encoding.html editing/pasteboard/copy-paste-float.html http/tests/misc/SVGFont-delayed-load.html fast/encoding/bom-in-content-utf16.html http/tests/fullscreen/fullscreenelement-different-origin.html http/tests/misc/char-encoding-in-hidden-charset-field-with-Shift_JIS.html compositing/animation/computed-style-during-delay.html http/tests/misc/async-script.html fast/css/hexColor-isDigit-assert.html fast/canvas/webgl/shader-precision-format.html http/tests/misc/empty-file-formdata.html http/tests/misc/char-encoding-in-hidden-charset-field-with-EUC-JP.html http/tests/misc/char-encoding-in-text-charset-field-with-value.html compositing/animation/animated-composited-inside-hidden.html http/tests/misc/char-encoding-in-hidden-charset-field-default.html editing/selection/thai-word-at-document-end.html compositing/transitions/scale-transition-no-start.html http/tests/eventsource/eventsource-events-after-close.html http/tests/misc/char-encoding-without-charset-field.html http/tests/misc/async-script-removed.html compositing/transitions/singular-scale-transition.html http/tests/fullscreen/fullscreenelement-same-origin.html http/tests/misc/char-encoding-in-hidden-charset-field-with-get-method.html http/tests/misc/char-encoding-in-hidden-charset-field-with-accept-charset.html editing/pasteboard/input-with-visibility-hidden.html
WebKit Review Bot
Comment 3 2012-08-03 22:06:09 PDT
Created attachment 156513 [details] Archive of layout-test-results from gce-cr-linux-01 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Adam Barth
Comment 4 2012-08-03 23:05:01 PDT
Comment on attachment 156506 [details] Patch Looks like you might still have some test failures.
Ryosuke Niwa
Comment 5 2012-08-04 15:58:37 PDT
Committed r124705: <http://trac.webkit.org/changeset/124705>
Ryosuke Niwa
Comment 6 2012-08-04 17:45:13 PDT
Tests fixed in http://trac.webkit.org/changeset/124707 and http://trac.webkit.org/changeset/124708.
Ryosuke Niwa
Comment 7 2012-08-04 18:24:24 PDT
One more fix landed in http://trac.webkit.org/changeset/124710.
Note You need to log in before you can comment on or make changes to this bug.