Bug 92940

Summary: StringImpl created from literal should be BufferInternal
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: Web Template FrameworkAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, gyuyoung.kim, joepeck, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 145120    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Benjamin Poulain
Reported 2012-08-01 22:03:05 PDT
I made a last minute change that caused createFromLiteral() to use BufferOwned instead of BufferInternal. On destruction, such strings are trying to delete the read only char* string.
Attachments
Patch (18.58 KB, patch)
2012-08-01 22:39 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (21.22 KB, patch)
2012-08-02 14:57 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (20.53 KB, patch)
2012-08-02 16:06 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2012-08-01 22:39:10 PDT
Created attachment 155975 [details] Patch
WebKit Review Bot
Comment 2 2012-08-01 22:40:43 PDT
Attachment 155975 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/te..." exit_code: 1 Tools/TestWebKitAPI/Tests/WTF/AtomicString.cpp:36: Consider using ASSERT_EQ instead of ASSERT_TRUE(a == b) [readability/check] [2] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Benjamin Poulain
Comment 3 2012-08-01 22:42:24 PDT
> Tools/TestWebKitAPI/Tests/WTF/AtomicString.cpp:36: Consider using ASSERT_EQ instead of ASSERT_TRUE(a == b) [readability/check] [2] This is expected. I did not change that because ASSERT_EQ does not use our operator==.
Gyuyoung Kim
Comment 4 2012-08-01 23:57:57 PDT
Comment on attachment 155975 [details] Patch Attachment 155975 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13411769
Benjamin Poulain
Comment 5 2012-08-02 14:57:23 PDT
Created attachment 156176 [details] Patch
WebKit Review Bot
Comment 6 2012-08-02 15:00:43 PDT
Attachment 156176 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/te..." exit_code: 1 Tools/TestWebKitAPI/Tests/WTF/AtomicString.cpp:36: Consider using ASSERT_EQ instead of ASSERT_TRUE(a == b) [readability/check] [2] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 7 2012-08-02 15:50:37 PDT
Comment on attachment 156176 [details] Patch Attachment 156176 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13404972
Benjamin Poulain
Comment 8 2012-08-02 16:06:40 PDT
Created attachment 156191 [details] Patch
WebKit Review Bot
Comment 9 2012-08-02 16:10:05 PDT
Attachment 156191 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/te..." exit_code: 1 Tools/TestWebKitAPI/Tests/WTF/AtomicString.cpp:36: Consider using ASSERT_EQ instead of ASSERT_TRUE(a == b) [readability/check] [2] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Benjamin Poulain
Comment 10 2012-08-03 07:37:42 PDT
Comment on attachment 156191 [details] Patch Clearing flags on attachment: 156191 Committed r124611: <http://trac.webkit.org/changeset/124611>
Benjamin Poulain
Comment 11 2012-08-03 07:37:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.