Bug 92887

Summary: run-perf-tests throws an exception when the output json is malformed
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: New BugsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77037    
Attachments:
Description Flags
Patch dpranke: review+

Ryosuke Niwa
Reported 2012-08-01 10:49:02 PDT
run-perf-tests throws an exception when the output json is malformed
Attachments
Patch (13.92 KB, patch)
2012-08-01 10:58 PDT, Ryosuke Niwa 		dpranke: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-08-01 10:58:23 PDT
Created attachment 155843 [details] Patch
Dirk Pranke
Comment 2 2012-08-01 11:03:21 PDT
Comment on attachment 155843 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155843&action=review > Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:56 > + _EXIT_CODE_BAD_PREPARATION = -5 Nit: the leading underscore makes these look like they're supposed to be private, but you return them from run(); should they be public (and have no leading underscore)?
Ryosuke Niwa
Comment 3 2012-08-01 11:20:15 PDT
(In reply to comment #2) > (From update of attachment 155843 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=155843&action=review > > > Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:56 > > + _EXIT_CODE_BAD_PREPARATION = -5 > > Nit: the leading underscore makes these look like they're supposed to be private, but you return them from run(); should they be public (and have no leading underscore)? Yeah, I should get rid of underscores. Will do. Thanks.
Ryosuke Niwa
Comment 4 2012-08-01 11:23:32 PDT
Committed r124349: <http://trac.webkit.org/changeset/124349>
Note You need to log in before you can comment on or make changes to this bug.