Bug 92851

Summary: Export StringImpl::sizeInBytes() with WTF_EXPORT_STRING_API
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: Web Template FrameworkAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: morrita, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 76257    
Attachments:
Description Flags
Patch none

Patrick R. Gansterer
Reported 2012-08-01 01:08:17 PDT
Export StringImpl::sizeInBytes() with WTF_EXPORT_STRING_API
Attachments
Patch (1.20 KB, patch)
2012-08-01 01:12 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2012-08-01 01:12:28 PDT
Created attachment 155744 [details] Patch
Hajime Morrita
Comment 2 2012-08-01 02:22:47 PDT
Comment on attachment 155744 [details] Patch Looks good. By the way, Could you address https://bugs.webkit.org/show_bug.cgi?id=92624#c8 in separate patch in some timing? I'm sorry that my suggestion there was wrong...
Patrick R. Gansterer
Comment 3 2012-08-01 02:26:26 PDT
(In reply to comment #2) > (From update of attachment 155744 [details]) > Looks good. > > By the way, Could you address https://bugs.webkit.org/show_bug.cgi?id=92624#c8 in separate > patch in some timing? I'm sorry that my suggestion there was wrong... I'm waiting for some response from Darin currently. My plan was to create a patch with a "_PRIVATE_" in the macro name at the weekend, if there is no response until then and CC him. -> It's on my list. :-)
Hajime Morrita
Comment 4 2012-08-01 02:36:36 PDT
> I'm waiting for some response from Darin currently. My plan was to create a patch with a "_PRIVATE_" in the macro name at the weekend, if there is no response until then and CC him. -> It's on my list. :-) Sounds good :-)
WebKit Review Bot
Comment 5 2012-08-01 05:24:10 PDT
Comment on attachment 155744 [details] Patch Clearing flags on attachment: 155744 Committed r124328: <http://trac.webkit.org/changeset/124328>
WebKit Review Bot
Comment 6 2012-08-01 05:24:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.