Bug 92830

Summary: Read tag names and attributes from the saved tokens in HTMLElementStack
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: DOMAssignee: Kwang Yul Seo <skyul>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 92838    
Bug Blocks: 92057    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Kwang Yul Seo
Reported 2012-07-31 19:52:34 PDT
This is a follow-up patch for r123577. Changed top()->hasTagName(x) with topStackItem()->hasTagName(x).
Attachments
Patch (2.45 KB, patch)
2012-07-31 19:55 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Patch (2.46 KB, patch)
2012-07-31 20:06 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Patch (5.01 KB, patch)
2012-07-31 22:19 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2012-07-31 19:55:58 PDT
Created attachment 155707 [details] Patch
Kwang Yul Seo
Comment 2 2012-07-31 20:06:40 PDT
Created attachment 155709 [details] Patch
Kwang Yul Seo
Comment 3 2012-07-31 20:28:36 PDT
(In reply to comment #2) > Created an attachment (id=155709) [details] > Patch I should have replaced item->element()->hasTagName(x) with item->hasTagName(x) too. I will upload the updated patch.
Kwang Yul Seo
Comment 4 2012-07-31 22:19:29 PDT
Created attachment 155721 [details] Patch
Kwang Yul Seo
Comment 5 2012-07-31 22:21:37 PDT
(In reply to comment #4) > Created an attachment (id=155721) [details] > Patch This patch revealed a bug in the previous patches. Please review Bug 92838 first.
Kwang Yul Seo
Comment 6 2012-08-01 15:57:01 PDT
Comment on attachment 155721 [details] Patch Clearing flags on attachment: 155721 Committed r124379: <http://trac.webkit.org/changeset/124379>
Kwang Yul Seo
Comment 7 2012-08-01 15:57:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.