Bug 92611

Summary: Prohibit having AuthorShadowDOM of input or textarea for a while and have a flag to enable it in Internals.
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dominicc, gustavo, hayato, mifenton, morrita, philn, tasak, tkent, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 82313    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from gce-cr-linux-07
none
Patch for landing none

Shinya Kawanaka
Reported 2012-07-29 21:52:52 PDT
Unfortunately when fixing bugs of replaced elements, a lot of crashes happens in input element. The primary reason is that the element in input Shadow DOM assumes that when an input element has a renderer, the elements in Shadow DOM also have renderers. This does not hold currently. So we woud like to prohibit adding Author Shadow DOM to input again. Also, we would like to introduce a flag to enable it for testing purpose. When we make input element AuthorShadowDOM-ready, let remove this restriction.
Attachments
Patch (12.23 KB, patch)
2012-07-29 23:04 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (13.28 KB, patch)
2012-07-29 23:58 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (13.57 KB, patch)
2012-07-30 00:11 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (14.98 KB, patch)
2012-07-30 00:51 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from gce-cr-linux-07 (706.08 KB, application/zip)
2012-07-30 03:57 PDT, WebKit Review Bot 		no flags
Details
Patch for landing (16.68 KB, patch)
2012-07-30 04:30 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-07-29 23:04:52 PDT
Created attachment 155211 [details] Patch
Early Warning System Bot
Comment 2 2012-07-29 23:17:09 PDT
Comment on attachment 155211 [details] Patch Attachment 155211 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13388333
Early Warning System Bot
Comment 3 2012-07-29 23:19:47 PDT
Comment on attachment 155211 [details] Patch Attachment 155211 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13385440
Shinya Kawanaka
Comment 4 2012-07-29 23:21:45 PDT
Actually we should disable AuthorShadowDOM for textarea also...
Build Bot
Comment 5 2012-07-29 23:29:43 PDT
Comment on attachment 155211 [details] Patch Attachment 155211 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13384483
Shinya Kawanaka
Comment 6 2012-07-29 23:58:03 PDT
Created attachment 155218 [details] Patch
Shinya Kawanaka
Comment 7 2012-07-30 00:11:11 PDT
Created attachment 155221 [details] Patch
Build Bot
Comment 8 2012-07-30 00:33:30 PDT
Comment on attachment 155221 [details] Patch Attachment 155221 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13391263
Shinya Kawanaka
Comment 9 2012-07-30 00:51:23 PDT
Created attachment 155226 [details] Patch
WebKit Review Bot
Comment 10 2012-07-30 03:57:14 PDT
Comment on attachment 155226 [details] Patch Attachment 155226 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13391316 New failing tests: fast/dom/shadow/shadowdom-for-form-associated-element-useragent.html
WebKit Review Bot
Comment 11 2012-07-30 03:57:20 PDT
Created attachment 155248 [details] Archive of layout-test-results from gce-cr-linux-07 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-07 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Shinya Kawanaka
Comment 12 2012-07-30 04:30:54 PDT
Created attachment 155254 [details] Patch for landing
WebKit Review Bot
Comment 13 2012-07-30 08:16:41 PDT
Comment on attachment 155254 [details] Patch for landing Clearing flags on attachment: 155254 Committed r124027: <http://trac.webkit.org/changeset/124027>
WebKit Review Bot
Comment 14 2012-07-30 08:16:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.