Bug 92364

Summary: [WK2] WebPage::handleEditingKeyboardEvent does not check whether the node allows editing.
Product: WebKit Reporter: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Component: WebKit2Assignee: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Status: RESOLVED FIXED    
Severity: Normal CC: kenneth, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 61838    
Attachments:
Description Flags
patch none

Mikhail Pozdnyakov
Reported 2012-07-26 04:08:37 PDT
WebPage::handleEditingKeyboardEvent does not check whether the node allows editing. Affects the behavior of fast/events/key-events-in-input-button.html test.
Attachments
patch (1.57 KB, patch)
2012-07-26 04:14 PDT, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mikhail Pozdnyakov
Comment 1 2012-07-26 04:14:08 PDT
Created attachment 154607 [details] patch
Kenneth Rohde Christiansen
Comment 2 2012-07-26 04:40:01 PDT
Comment on attachment 154607 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=154607&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2149 > + // Don't allow text insertion for nodes that cannot edit. > + if (!frame->editor()->canEdit()) You might not always have an editor() either.
Mikhail Pozdnyakov
Comment 3 2012-07-26 04:46:40 PDT
(In reply to comment #2) > (From update of attachment 154607 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=154607&action=review > > > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2149 > > + // Don't allow text insertion for nodes that cannot edit. > > + if (!frame->editor()->canEdit()) > > You might not always have an editor() either. this function ends already with following: return frame->editor()->insertText(evt->keyEvent()->text(), evt); and here is from Frame.h inline Editor* Frame::editor() const { return &m_editor; }
Kenneth Rohde Christiansen
Comment 4 2012-07-26 04:48:38 PDT
Ah maybe that changed then
WebKit Review Bot
Comment 5 2012-07-26 05:10:42 PDT
Comment on attachment 154607 [details] patch Clearing flags on attachment: 154607 Committed r123732: <http://trac.webkit.org/changeset/123732>
WebKit Review Bot
Comment 6 2012-07-26 05:10:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.