Bug 92235

Summary: [EFL][WK2] Keyboard events miss key location data.
Product: WebKit Reporter: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Component: WebKit EFLAssignee: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, lucas.de.marchi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 61838    
Attachments:
Description Flags
patch
none
patch v2 none

Mikhail Pozdnyakov
Reported 2012-07-25 03:38:04 PDT
EFL WK2 does not initialize WebKeyboardEvent::m_isKeypad field. This causes failure of fast/events/keydown-numpad-keys.html test.
Attachments
patch (3.39 KB, patch)
2012-07-25 03:45 PDT, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
patch v2 (3.37 KB, patch)
2012-07-25 04:23 PDT, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mikhail Pozdnyakov
Comment 1 2012-07-25 03:45:48 PDT
Created attachment 154314 [details] patch
Chris Dumez
Comment 2 2012-07-25 04:06:08 PDT
Comment on attachment 154314 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=154314&action=review > Source/WebKit2/Shared/efl/WebEventFactory.cpp:47 > +static const char* keyPadPrefix = "KP_"; Please use: static const char keyPadPrefix[] = "KP_"; > Source/WebKit2/Shared/efl/WebEventFactory.cpp:163 > + const String& keyName = String(event->key); Why not use simply "String keyName(event->key);" ? > Source/WebKit2/Shared/efl/WebEventFactory.cpp:180 > + const String& keyName = String(event->key); ditto.
Gyuyoung Kim
Comment 3 2012-07-25 04:12:32 PDT
Comment on attachment 154314 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=154314&action=review > Source/WebKit2/ChangeLog:9 > + This caused failure of fast/events/keydown-numpad-keys.html test. Don't you need to unskip this test ?
Mikhail Pozdnyakov
Comment 4 2012-07-25 04:13:53 PDT
(In reply to comment #3) > (From update of attachment 154314 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=154314&action=review > > > Source/WebKit2/ChangeLog:9 > > + This caused failure of fast/events/keydown-numpad-keys.html test. > > Don't you need to unskip this test ? It's already unskipped and works well for EFL WK1.
Mikhail Pozdnyakov
Comment 5 2012-07-25 04:23:05 PDT
Created attachment 154323 [details] patch v2 Thanks for review, Chris!
Chris Dumez
Comment 6 2012-07-25 04:26:52 PDT
Comment on attachment 154323 [details] patch v2 LGTM. Thanks.
Gyuyoung Kim
Comment 7 2012-07-25 05:12:51 PDT
Comment on attachment 154323 [details] patch v2 Looks fine.
WebKit Review Bot
Comment 8 2012-07-27 03:47:38 PDT
Comment on attachment 154323 [details] patch v2 Clearing flags on attachment: 154323 Committed r123860: <http://trac.webkit.org/changeset/123860>
WebKit Review Bot
Comment 9 2012-07-27 03:47:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.