Bug 92230

Summary: [Forms] Move HTMLInputElement::updateInnerTextValue to InputType class
Product: WebKit Reporter: yosin
Component: FormsAssignee: yosin
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 88970    
Attachments:
Description Flags
Patch 1
none
Patch 1 none

yosin
Reported 2012-07-25 01:34:39 PDT
To implement, multiple field time input UI, we need to tell TimeInputType about changing value. This can be done by making HTMLInputElement::updateInnerTextValue() to call InputType::updateInnerValue(). Here is list of call site of updateInnerTextValue() - DateInputValue::handleBlurEvent() - HTMLInputElement::copyNonAttributePropertiesFromElement() - HTMLInputElement::parseAttribute() -- for changing value via setAttribute() - HTMLInputElement::setSuggestedValue() - HTMLInputElement::updateType() - NumberInputType::handleBlurEvent() - TextFieldInputType::setValue()
Attachments
Patch 1 (4.47 KB, patch)
2012-07-25 02:02 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Patch 1 (9.11 KB, patch)
2012-07-25 03:04 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
yosin
Comment 1 2012-07-25 02:02:11 PDT
Created attachment 154295 [details] Patch 1
yosin
Comment 2 2012-07-25 02:15:08 PDT
Comment on attachment 154295 [details] Patch 1 Could you review this patch? Thanks in advance.
Kent Tamura
Comment 3 2012-07-25 02:31:27 PDT
Comment on attachment 154295 [details] Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=154295&action=review > Source/WebCore/html/HTMLInputElement.cpp:493 > void HTMLInputElement::updateInnerTextValue() > { Please remove HTMLInputElement::updateInnerTextValue(). > Source/WebCore/html/InputType.h:262 > + virtual void updateInnerValue() { } Do not define function body in a header for virtual functions. It wastes build time. > Source/WebCore/html/TextFieldInputType.cpp:453 > +void TextFieldInputType::updateInnerValue() The function name should be updateInnerTextValue() because of consistency with 'innerText' functions though I don't like this name.
yosin
Comment 4 2012-07-25 03:04:28 PDT
Created attachment 154309 [details] Patch 1
yosin
Comment 5 2012-07-25 03:06:11 PDT
Comment on attachment 154309 [details] Patch 1 Could you review this patch? Thanks in advance. = Changes since the last review = * Remove HTMLInputElement::updateInnerTextValue() * Update call sites of HTMLInputElement::updateInnerTextValue() * Use InputType::updateInnerTextValue() instead of updateInnerValue()
Kent Tamura
Comment 6 2012-07-25 04:12:26 PDT
Comment on attachment 154309 [details] Patch 1 ok
yosin
Comment 7 2012-07-25 18:01:21 PDT
Comment on attachment 154309 [details] Patch 1 Clearing flags on attachment: 154309 Committed r123687: <http://trac.webkit.org/changeset/123687>
yosin
Comment 8 2012-07-25 18:01:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.