Bug 92143

Summary: Web Inspector: simplify handling of status bar items
Product: WebKit Reporter: Andrey Kosyakov <caseq>
Component: Web Inspector (Deprecated)Assignee: Andrey Kosyakov <caseq>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch pfeldman: review+

Andrey Kosyakov
Reported 2012-07-24 11:01:37 PDT
This attempts to resolve a number of problems with current status bar items management, in particular: - explicit handling of some panel/view items by generic code in Drawer and inspector.js (in particular, search counters and timeline panel counters) - a lot of absolute positioned items in status bars, occasionally conflicting with each other and preventing usage of static flow to position other items - "anchored" status bar items that used to include some icons on the left and counters on the right
Attachments
Patch (26.08 KB, patch)
2012-07-24 11:06 PDT, Andrey Kosyakov 		no flags
DetailsFormatted DiffDiff
Patch (26.22 KB, patch)
2012-07-25 09:41 PDT, Andrey Kosyakov 		no flags
DetailsFormatted DiffDiff
Patch (26.40 KB, patch)
2012-07-25 10:40 PDT, Andrey Kosyakov 		no flags
DetailsFormatted DiffDiff
Patch (26.74 KB, patch)
2012-07-26 06:00 PDT, Andrey Kosyakov 		no flags
DetailsFormatted DiffDiff
Patch (26.85 KB, patch)
2012-07-26 06:31 PDT, Andrey Kosyakov 		no flags
DetailsFormatted DiffDiff
Patch (26.57 KB, patch)
2012-07-26 06:39 PDT, Andrey Kosyakov 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Andrey Kosyakov
Comment 1 2012-07-24 11:06:52 PDT
Created attachment 154109 [details] Patch
Andrey Kosyakov
Comment 2 2012-07-25 09:41:50 PDT
Created attachment 154376 [details] Patch
Vsevolod Vlasov
Comment 3 2012-07-25 10:03:36 PDT
Comment on attachment 154376 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154376&action=review > Source/WebCore/inspector/front-end/inspector.html:235 > + <div id="panel-status-bar-placeholder" class="status-bar"><div id="panel-status-bar-resizer"></div></div> panel-status-bar > Source/WebCore/inspector/front-end/inspector.html:239 > + <div id="inner-status-bar"> main-status-bar-inner > Source/WebCore/inspector/front-end/inspector.html:240 > + <div id="panel-status-bar"></div> panel-status-bar-items
Andrey Kosyakov
Comment 4 2012-07-25 10:40:13 PDT
Created attachment 154389 [details] Patch
Andrey Kosyakov
Comment 5 2012-07-26 06:00:22 PDT
Created attachment 154627 [details] Patch
Andrey Kosyakov
Comment 6 2012-07-26 06:31:44 PDT
Created attachment 154639 [details] Patch
Andrey Kosyakov
Comment 7 2012-07-26 06:39:24 PDT
Created attachment 154640 [details] Patch
Pavel Feldman
Comment 8 2012-07-26 08:32:00 PDT
Comment on attachment 154640 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154640&action=review > Source/WebCore/inspector/front-end/inspector.html:238 > + <div id="main-status-bar" class="status-bar"> Please move this into the JavaScript.
Andrey Kosyakov
Comment 9 2012-07-26 10:56:06 PDT
Committed r123770: <http://trac.webkit.org/changeset/123770>
Note You need to log in before you can comment on or make changes to this bug.