Bug 92103

Summary: HarfBuzzFaceNG.h forward declarations conflict with newer versions of Harfbuzz
Product: WebKit Reporter: Dominik Röttsches (drott) <d-r>
Component: PlatformAssignee: Dominik Röttsches (drott) <d-r>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, gustavo, jochen, kenneth, morrita, pnormand, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 91853    
Attachments:
Description Flags
Patch
none
Including header instead of fw declarations. none

Dominik Röttsches (drott)
Reported 2012-07-24 05:44:29 PDT
I'd suggest to include the header instead.
Attachments
Patch (1.82 KB, patch)
2012-07-24 05:50 PDT, Dominik Röttsches (drott) 		no flags
DetailsFormatted DiffDiff
Including header instead of fw declarations. (1.62 KB, patch)
2012-07-24 06:32 PDT, Dominik Röttsches (drott) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dominik Röttsches (drott)
Comment 1 2012-07-24 05:50:21 PDT
Created attachment 154030 [details] Patch
jochen
Comment 2 2012-07-24 06:00:02 PDT
Comment on attachment 154030 [details] Patch The patch looks good View in context: https://bugs.webkit.org/attachment.cgi?id=154030&action=review > Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzNGFace.h:35 > +// uses different typedefs for hb_font_t and hb_face_t compared to harfbuzz release 0.9.0. I'd drop the comment as it's bound to get out of date. The explanation in the ChangeLog should be good enough.
Dominik Röttsches (drott)
Comment 3 2012-07-24 06:32:05 PDT
Created attachment 154042 [details] Including header instead of fw declarations.
Dominik Röttsches (drott)
Comment 4 2012-07-24 06:32:47 PDT
(In reply to comment #2) > (From update of attachment 154030 [details]) > The patch looks good > > View in context: https://bugs.webkit.org/attachment.cgi?id=154030&action=review > > > Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzNGFace.h:35 > > +// uses different typedefs for hb_font_t and hb_face_t compared to harfbuzz release 0.9.0. > > I'd drop the comment as it's bound to get out of date. The explanation in the ChangeLog should be good enough. Done. Thanks for taking a look.
WebKit Review Bot
Comment 5 2012-07-24 07:41:08 PDT
Comment on attachment 154042 [details] Including header instead of fw declarations. Clearing flags on attachment: 154042 Committed r123475: <http://trac.webkit.org/changeset/123475>
WebKit Review Bot
Comment 6 2012-07-24 07:41:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.