Bug 92102

Summary: [EFL] Get rid of pango backend support once harfbuzz-ng is working
Product: WebKit Reporter: Dominik Röttsches (drott) <d-r>
Component: WebKit EFLAssignee: Dominik Röttsches (drott) <d-r>
Status: RESOLVED FIXED    
Severity: Normal CC: antognolli+webkit, dbates, g.czajkowski, gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, rwlbuis, ryuan.choi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 91853    
Attachments:
Description Flags
Removing Pango from EFL buildsystem.
none
Removing Pango from EFL buildsystem, v2. LibFindMacros removed. none

Dominik Röttsches (drott)
Reported 2012-07-24 05:36:37 PDT
As per http://behdad.org/text/ I think we should get rid of the pango backend once we have harfbuzz-ng support.
Attachments
Removing Pango from EFL buildsystem. (6.82 KB, patch)
2012-08-17 06:55 PDT, Dominik Röttsches (drott) 		no flags
DetailsFormatted DiffDiff
Removing Pango from EFL buildsystem, v2. LibFindMacros removed. (11.27 KB, patch)
2012-08-20 01:03 PDT, Dominik Röttsches (drott) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2012-07-24 18:51:21 PDT
If you wanna stop to support pango backend in EFL port, I think you need to notify this removal to webkit-efl as well.
Dominik Röttsches (drott)
Comment 2 2012-08-17 06:55:51 PDT
Created attachment 159114 [details] Removing Pango from EFL buildsystem.
Dominik Röttsches (drott)
Comment 3 2012-08-17 06:59:18 PDT
(In reply to comment #2) > Created an attachment (id=159114) [details] > Removing Pango from EFL buildsystem. Since there were no objections on webkit-efl list.
Raphael Kubo da Costa (:rakuco)
Comment 4 2012-08-17 09:04:57 PDT
Comment on attachment 159114 [details] Removing Pango from EFL buildsystem. This is awesome, I love code cleanups. In theory, you can also get rid of LibFindMacros.cmake, as FindPango.cmake was its last user.
Ryuan Choi
Comment 5 2012-08-19 14:32:04 PDT
As I mentioned in webkit-efl mailing list. I don't have objection for removing. However, please give me some time for webkit/tizen to catch up trunk. As I mentioned, tizen/webkit still use FontPango.cpp and FindPango.cmake And also, I heard that internal implementation of spellchecker had pango dependency. If this is not urgent task, I want to keep this until tizen/webkit solved related issues.
Dominik Röttsches (drott)
Comment 6 2012-08-20 01:03:45 PDT
Created attachment 159351 [details] Removing Pango from EFL buildsystem, v2. LibFindMacros removed.
Dominik Röttsches (drott)
Comment 7 2012-08-20 01:08:39 PDT
(In reply to comment #5) > As I mentioned in webkit-efl mailing list. > I don't have objection for removing. > However, please give me some time for webkit/tizen to catch up trunk. > > As I mentioned, tizen/webkit still use FontPango.cpp and FindPango.cmake > If this is not urgent task, > I want to keep this until tizen/webkit solved related issues. I think, we should clean this up in upstream quickly. You can keep a local patch for the pieces that you still need. Since there's no other dependency and it's only removing code and files, I think the maintenance overhead for keeping this as a local change is rather small.
WebKit Review Bot
Comment 8 2012-08-20 02:09:42 PDT
Comment on attachment 159351 [details] Removing Pango from EFL buildsystem, v2. LibFindMacros removed. Clearing flags on attachment: 159351 Committed r126010: <http://trac.webkit.org/changeset/126010>
WebKit Review Bot
Comment 9 2012-08-20 02:09:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.