Bug 91771

Summary: create SourceBuffer and SourceBufferList objects
Product: WebKit Reporter: Anna Cavender <annacc>
Component: MediaAssignee: Anna Cavender <annacc>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, acolwell, eric.carlson, feature-media-reviews, gyuyoung.kim, ojan, rakuco, vestbo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 90819    
Attachments:
Description Flags
Patch
none
fix windows build files
none
no diff, hoping win bot will run this time
none
Patch for landing none

Anna Cavender
Reported 2012-07-19 12:38:59 PDT
SourceBuffer and SourceBufferList objects are needed in order to implement the new object-oriented MediaSource API: http://dvcs.w3.org/hg/html-media/raw-file/tip/media-source/media-source.html#sourcebuffer http://dvcs.w3.org/hg/html-media/raw-file/tip/media-source/media-source.html#sourcebufferlist
Attachments
Patch (34.23 KB, patch)
2012-07-19 13:22 PDT, Anna Cavender 		no flags
DetailsFormatted DiffDiff
fix windows build files (44.59 KB, patch)
2012-07-20 12:28 PDT, Anna Cavender 		no flags
DetailsFormatted DiffDiff
no diff, hoping win bot will run this time (44.59 KB, patch)
2012-07-23 16:49 PDT, Anna Cavender 		no flags
DetailsFormatted DiffDiff
Patch for landing (44.58 KB, patch)
2012-07-24 10:28 PDT, Anna Cavender 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Anna Cavender
Comment 1 2012-07-19 13:22:34 PDT
Created attachment 153333 [details] Patch
Build Bot
Comment 2 2012-07-19 13:50:29 PDT
Comment on attachment 153333 [details] Patch Attachment 153333 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13301083
Anna Cavender
Comment 3 2012-07-20 12:28:35 PDT
Created attachment 153564 [details] fix windows build files
Anna Cavender
Comment 4 2012-07-23 16:49:03 PDT
Created attachment 153898 [details] no diff, hoping win bot will run this time
Eric Carlson
Comment 5 2012-07-24 10:08:29 PDT
Comment on attachment 153898 [details] no diff, hoping win bot will run this time View in context: https://bugs.webkit.org/attachment.cgi?id=153898&action=review > Source/WebCore/Modules/mediasource/SourceBuffer.cpp:59 > + UNUSED_PARAM(data); > + // FIXME(91773): append the data to the media source. Nit: UNUSED_PARAM() isn't necessary if you don't name the parameter.
Anna Cavender
Comment 6 2012-07-24 10:27:27 PDT
Comment on attachment 153898 [details] no diff, hoping win bot will run this time Thanks, Eric! View in context: https://bugs.webkit.org/attachment.cgi?id=153898&action=review >> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:59 >> + // FIXME(91773): append the data to the media source. > > Nit: UNUSED_PARAM() isn't necessary if you don't name the parameter. Gone.
Anna Cavender
Comment 7 2012-07-24 10:28:10 PDT
Created attachment 154098 [details] Patch for landing
WebKit Review Bot
Comment 8 2012-07-24 13:45:04 PDT
Comment on attachment 154098 [details] Patch for landing Clearing flags on attachment: 154098 Committed r123522: <http://trac.webkit.org/changeset/123522>
WebKit Review Bot
Comment 9 2012-07-24 13:45:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.