Bug 91726

Summary: Update notifications to latest spec
Product: WebKit Reporter: Jon Lee <jonlee>
Component: DOMAssignee: Jon Lee <jonlee>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, haraken, ojan, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.7   
Bug Depends on:    
Bug Blocks: 80472    
Attachments:
Description Flags
Patch
none
Patch
none
Patch ap: review+

Jon Lee
Reported 2012-07-19 01:13:29 PDT
1) Added "lang" attribute. 2) Remove event listeners from dictionary. 3) Rename "iconUrl" to "icon".
Attachments
Patch (21.79 KB, patch)
2012-07-20 13:28 PDT, Jon Lee 		no flags
DetailsFormatted DiffDiff
Patch (20.42 KB, patch)
2012-09-07 17:08 PDT, Jon Lee 		no flags
DetailsFormatted DiffDiff
Patch (20.42 KB, patch)
2012-09-10 13:28 PDT, Jon Lee 		ap: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2012-07-19 01:13:52 PDT
<rdar://problem/11910451>
Jon Lee
Comment 2 2012-07-20 13:28:35 PDT
Created attachment 153583 [details] Patch
Jon Lee
Comment 3 2012-09-07 16:53:45 PDT
Item 2) above was already covered in bug 95538. But add a new item, which is to make the variables related to HTML notifications only available for legacy notifications.
Jon Lee
Comment 4 2012-09-07 17:08:11 PDT
Created attachment 162912 [details] Patch
Jon Lee
Comment 5 2012-09-10 13:28:43 PDT
Created attachment 163194 [details] Patch
Alexey Proskuryakov
Comment 6 2012-09-10 13:35:50 PDT
Comment on attachment 163194 [details] Patch OK. Abbrs make me unhappy.
Jon Lee
Comment 7 2012-09-10 15:12:23 PDT
Committed r128113: <http://trac.webkit.org/changeset/128113>
Note You need to log in before you can comment on or make changes to this bug.