Bug 91413

Summary:

Figure out what's wrong with my patch for the bug 91335

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

DOM

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

dglazkov, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Make sure I didn't regress HTMLCollection	none
Simplify length() and see if that fixes it	none
Second attempt to simplify length()	none
Disable backwards iteration	webkit.review.bot: commit-queue-
Archive of layout-test-results from gce-cr-linux-07	none
Archive of layout-test-results from gce-cr-linux-02	none
original patch with modified manipulation.html to get more info out of the test	none

Ryosuke Niwa

Reported 2012-07-16 12:19:46 PDT

Need to abuse EWS here.

Attachments
Make sure I didn't regress HTMLCollection (43.57 KB, patch) 2012-07-16 12:20 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Simplify length() and see if that fixes it (48.56 KB, patch) 2012-07-16 13:00 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Second attempt to simplify length() (48.57 KB, patch) 2012-07-16 13:12 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Disable backwards iteration (48.07 KB, patch) 2012-07-16 13:30 PDT, Ryosuke Niwa	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from gce-cr-linux-07 (501.20 KB, application/zip) 2012-07-16 17:00 PDT, WebKit Review Bot	no flags	Details
Archive of layout-test-results from gce-cr-linux-02 (657.02 KB, application/zip) 2012-07-16 18:05 PDT, WebKit Review Bot	no flags	Details
original patch with modified manipulation.html to get more info out of the test (51.91 KB, patch) 2012-07-16 19:28 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2012-07-16 12:20:30 PDT

Created attachment 152583 [details] Make sure I didn't regress HTMLCollection

Ryosuke Niwa

Comment 2 2012-07-16 13:00:11 PDT

Created attachment 152594 [details] Simplify length() and see if that fixes it

Ryosuke Niwa

Comment 3 2012-07-16 13:12:19 PDT

Created attachment 152599 [details] Second attempt to simplify length()

Ryosuke Niwa

Comment 4 2012-07-16 13:30:09 PDT

Created attachment 152602 [details] Disable backwards iteration

WebKit Review Bot

Comment 5 2012-07-16 17:00:18 PDT

Comment on attachment 152602 [details] Disable backwards iteration Attachment 152602 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13259181 New failing tests: perf/htmlcollection-last-item.html

WebKit Review Bot

Comment 6 2012-07-16 17:00:21 PDT

Created attachment 152644 [details] Archive of layout-test-results from gce-cr-linux-07 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-07 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

WebKit Review Bot

Comment 7 2012-07-16 18:05:22 PDT

Comment on attachment 152602 [details] Disable backwards iteration Attachment 152602 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13254448 New failing tests: perf/htmlcollection-last-item.html

WebKit Review Bot

Comment 8 2012-07-16 18:05:26 PDT

Created attachment 152665 [details] Archive of layout-test-results from gce-cr-linux-02 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

Ryosuke Niwa

Comment 9 2012-07-16 19:28:17 PDT

Created attachment 152681 [details] original patch with modified manipulation.html to get more info out of the test

Ryosuke Niwa

Comment 10 2012-07-18 00:00:18 PDT

*** This bug has been marked as a duplicate of bug 91587 ***

Note You need to log in before you can comment on or make changes to this bug.