Bug 91144

Summary: Merge HTMLCollectionWithArrayStorage into HTMLCollection
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, arko, darin, gustavo, kling, koivisto, sam, vsevik, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 89919    
Attachments:
Description Flags
Patch
gustavo: commit-queue-
Patch andersca: review+

Ryosuke Niwa
Reported 2012-07-12 13:46:19 PDT
http://trac.webkit.org/changeset/122345 introduced HTMLCollectionWithArrayStorage to share more code between HTMLFormCollection::item and HTMLPropertiesCollection::item. But we can do better by merging it to HTMLCollection::item. In fact, we can also get rid of HTMLCollection::calcLength as well.
Attachments
Patch (19.27 KB, patch)
2012-07-12 15:19 PDT, Ryosuke Niwa 		gustavo: commit-queue-
DetailsFormatted DiffDiff
Patch (19.36 KB, patch)
2012-07-12 15:30 PDT, Ryosuke Niwa 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-07-12 15:19:17 PDT
Created attachment 152076 [details] Patch
Gustavo Noronha (kov)
Comment 2 2012-07-12 15:26:30 PDT
Comment on attachment 152076 [details] Patch Attachment 152076 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/13202856
Ryosuke Niwa
Comment 3 2012-07-12 15:28:52 PDT
Comment on attachment 152076 [details] Patch (In reply to comment #2) > (From update of attachment 152076 [details]) > Attachment 152076 [details] did not pass gtk-ews (gtk): > Output: http://queues.webkit.org/results/13202856 Oh, oops. A bad merge :( Fixing now.
Ryosuke Niwa
Comment 4 2012-07-12 15:30:14 PDT
Created attachment 152080 [details] Patch
Ryosuke Niwa
Comment 5 2012-07-12 15:40:30 PDT
Committed r122518: <http://trac.webkit.org/changeset/122518>
Vsevolod Vlasov
Comment 6 2012-07-16 05:53:32 PDT
FYI this change causes http://code.google.com/p/chromium/issues/detail?id=137488
Ryosuke Niwa
Comment 7 2012-07-16 10:06:36 PDT
(In reply to comment #6) > FYI this change causes http://code.google.com/p/chromium/issues/detail?id=137488 Ah, I think I know what's happening there. Try adding arrayOffset = 0 to http://trac.webkit.org/browser/trunk/Source/WebCore/html/HTMLCollection.cpp?rev=122518#L323
Note You need to log in before you can comment on or make changes to this bug.