Bug 90978
| Summary: | [Qt] needs libWebCoreTestSupport | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Balazs Kelemen <kbalazs> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | cmarcelo, hausmann, jesus, kenneth, laszlo.gombos, ossy, rakuco, vestbo |
| Priority: | P2 | Keywords: | Qt, QtTriaged |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Balazs Kelemen
So far we exposed testing facilities via DumpRenderTreeSupportQt. This is not sufficient because it leaks public symbols to the library and we also want to expose cross-platform things, like WebCoreTestSupport. We should reuse other ports solution which is a separate non-product helper lib.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Balazs Kelemen
*** Bug 90346 has been marked as a duplicate of this bug. ***
Simon Hausmann
I think it's a good idea to take the test supporting code out of WebKit/qt and into a more central place.
Do you intend to have this library as a static library that is linked into the QtWebKit shared library and exports the necessary symbols?
Balazs Kelemen
(In reply to comment #2)
> I think it's a good idea to take the test supporting code out of WebKit/qt and into a more central place.
>
> Do you intend to have this library as a static library that is linked into the QtWebKit shared library and exports the necessary symbols?
I did not managed to look into this closely yet but I think we should not link it into QtWebKit. I think it should be a static library that links to QtWebKit which we can we link into drt/wtr.
Jesus Sanchez-Palencia
(In reply to comment #3)
> I did not managed to look into this closely yet but I think we should not link it into QtWebKit. I think it should be a static library that links to QtWebKit which we can we link into drt/wtr.
Are you working on this, Balazs?
Balazs Kelemen
(In reply to comment #4)
> (In reply to comment #3)
> > I did not managed to look into this closely yet but I think we should not link it into QtWebKit. I think it should be a static library that links to QtWebKit which we can we link into drt/wtr.
>
> Are you working on this, Balazs?
No, feel free to pick it up. Btw I think first we should solve bug 90262.
Jocelyn Turcotte
=== Bulk closing of Qt bugs ===
If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.
If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.