Bug 90921

Summary: [Chromium] Adjust DumpRenderTree ifdefs for Android
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED WONTFIX    
Severity: Normal CC: japhet, peter, tkent, tony, wangxianzhu, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66687    
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2012-07-10 17:05:04 PDT
[Chromium] Adjust DumpRenderTree ifdefs for Android
Attachments
Patch (3.37 KB, patch)
2012-07-10 17:12 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-07-10 17:12:04 PDT
Created attachment 151558 [details] Patch
Kent Tamura
Comment 2 2012-07-10 17:18:26 PDT
Comment on attachment 151558 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151558&action=review > Tools/DumpRenderTree/chromium/MockWebSpeechInputController.h:-30 > -#if ENABLE(INPUT_SPEECH) > - Why do you remove it? Android port doesn't have INPUT_SPEECH, and this class shouldn't be needed, right?
Adam Barth
Comment 3 2012-07-10 22:22:50 PDT
(In reply to comment #2) > (From update of attachment 151558 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=151558&action=review > > > Tools/DumpRenderTree/chromium/MockWebSpeechInputController.h:-30 > > -#if ENABLE(INPUT_SPEECH) > > - > > Why do you remove it? Android port doesn't have INPUT_SPEECH, and this class shouldn't be needed, right? I suspect it's referenced outside the ENABLE(INPUT_SPEECH) ifdef. We can try reverting it on the chromium-android branch, but it seemed easier to just upstream the change.
Peter Beverloo
Comment 4 2012-07-11 07:39:07 PDT
Comment on attachment 151558 [details] Patch There is no reason for these changes to live upstream, as they seem to be merge errors in our downstream branch. We should abandon this and remove the differences downstream instead, for which I've uploaded this patch: https://gerrit-int.chromium.org/#change,21574 Removing r? and cq? so it's clear to reviewers.
Adam Barth
Comment 5 2012-07-11 09:35:33 PDT
Ok.
Note You need to log in before you can comment on or make changes to this bug.