Bug 90895

Summary: [Qt] Make GraphicsSurface::create function platform specific.
Product: WebKit Reporter: Zeno Albisser <zeno>
Component: WebKit QtAssignee: Zeno Albisser <zeno>
Status: RESOLVED INVALID    
Severity: Normal CC: noam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 90881    
Attachments:
Description Flags
patch for review. none

Zeno Albisser
Reported 2012-07-10 10:47:48 PDT
In order to implement platform specific create behavior this function should be platform specific. We need this to be able to do platform specific initialization based on the provided flags, when implementing GraphicsSurfaceGLX.
Attachments
patch for review. (3.03 KB, patch)
2012-07-10 10:54 PDT, Zeno Albisser 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zeno Albisser
Comment 1 2012-07-10 10:54:56 PDT
Created attachment 151487 [details] patch for review.
Noam Rosenthal
Comment 2 2012-07-10 10:58:29 PDT
Comment on attachment 151487 [details] patch for review. Maybe we should combine this with the GLX patch? Otherwise it's hard to see the whole picture.
Zeno Albisser
Comment 3 2012-07-10 11:06:43 PDT
Comment on attachment 151487 [details] patch for review. As discussed on IRC I will instead make the functions platformCreate / platformImport static and return the instance back from there.
Zeno Albisser
Comment 4 2012-07-10 11:08:27 PDT
no separate patch needed.
Note You need to log in before you can comment on or make changes to this bug.