Bug 90326

Summary:

HTMLCollection should use DynamicNodeList's invalidation model

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

DOM

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, arko, darin, dglazkov, gustavo, haraken, kling, koivisto, ojan, philn, skyul, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

91046, 91178

Bug Blocks:

89919, 91571

Attachments:

Description	Flags
work in progress	none
Patch	none
Fixed builds	andersca: review+

Ryosuke Niwa

Reported 2012-06-29 17:29:17 PDT

Right now, HTMLCollection gets invalidated lazily by checking DOM tree version. However, various attempts to simplify DynamicNodeList's invalidation model proved that our current invalidation model for DynamicNodeList is indeed effective. We should make HTMLCollection use the same model.

Attachments
work in progress (6.28 KB, patch) 2012-06-29 17:31 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Patch (33.12 KB, patch) 2012-07-13 01:34 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Fixed builds (33.32 KB, patch) 2012-07-13 11:52 PDT, Ryosuke Niwa	andersca: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2012-06-29 17:31:21 PDT

Created attachment 150278 [details] work in progress Unfortunately, we have to do more refactoring around invalidateNodeListsCacheAfterAttributeChanged to avoid invalidating node lists and html collections when attribute that had changed don't affect node lists and html collections.

Ryosuke Niwa

Comment 2 2012-07-13 01:34:31 PDT

Created attachment 152186 [details] Patch

Build Bot

Comment 3 2012-07-13 01:52:50 PDT

Comment on attachment 152186 [details] Patch Attachment 152186 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13239018

Build Bot

Comment 4 2012-07-13 02:14:35 PDT

Comment on attachment 152186 [details] Patch Attachment 152186 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13230132

Early Warning System Bot

Comment 5 2012-07-13 02:29:23 PDT

Comment on attachment 152186 [details] Patch Attachment 152186 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13236046