Bug 90164

Summary: [Qt][DRT] Reset AcceleratedCompositingEnabled between tests
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, noam, ossy
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2012-06-28 05:15:45 PDT
They were unskipped by http://trac.webkit.org/changeset/121262 and they are always flakey with TEXT PASS. They pass one by one, but it seesm it is one more Qt-DRT sideeffect bug. You can find the diffs here: http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r121425%20%2839306%29/results.html
Attachments
Patch (1.46 KB, patch)
2012-06-28 05:53 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2012-06-28 05:34:40 PDT
[Qt] transforms/3d/*tests are flakey (TEXT PASS)
Csaba Osztrogonác
Comment 2 2012-06-28 05:37:53 PDT
AcceleratedCompositingEnabled isn't reset between tests now, and it made transforms/3d/*tests are flakey (TEXT PASS) AcceleratedCompositingEnabled is disabled by 13 css3/filters/* tests and isn't reenabled again by Qt-DRT. (Otherwise shouldn't transforms/3d/* tests pass with and without AC?)
Csaba Osztrogonác
Comment 3 2012-06-28 05:39:44 PDT
You can easily reproduce this bug: - Tools/Script/run-webkit-tests css3/filters transforms/3d -> flakey tests - Tools/Script/run-webkit-tests transforms/3d -> all tests pass
Csaba Osztrogonác
Comment 4 2012-06-28 05:53:52 PDT
Created attachment 149933 [details] Patch
Csaba Osztrogonác
Comment 5 2012-06-28 06:07:50 PDT
Comment on attachment 149933 [details] Patch Clearing flags on attachment: 149933 Committed r121426: <http://trac.webkit.org/changeset/121426>
Csaba Osztrogonác
Comment 6 2012-06-28 06:07:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.