Bug 90072

Summary: Use source.svn.SVN instead of source.oldsource.SVN
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: galpeter, lforschler, ossy, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 85887    
Bug Blocks: 90075    
Attachments:
Description Flags
Patch
none
patch none

Csaba Osztrogonác
Reported 2012-06-27 06:49:27 PDT
Because the old one is very old. :) And the newer one is good for us to make https://bugs.webkit.org/show_bug.cgi?id=85887 unittestable and we can make clean build request feature with it quite easily. Patch is coming soon.
Attachments
Patch (2.13 KB, patch)
2012-06-27 06:55 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
patch (1.89 KB, patch)
2012-08-14 05:53 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2012-06-27 06:55:45 PDT
Created attachment 149741 [details] Patch
Csaba Osztrogonác
Comment 2 2012-06-27 07:08:28 PDT
Comment on attachment 149741 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149741&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:13 > -from buildbot.steps import master, shell, source, transfer, trigger > +from buildbot.steps import master, shell, transfer, trigger > +from buildbot.steps.source.svn import SVN We need it, because steps.source.__init__.py makes oldsource default: from buildbot.steps.source.oldsource import _ComputeRepositoryURL, Source, CVS, \ SVN, Git, Darcs, Repo, Bzr, Mercurial, P4, P4Sync, Monotone, BK > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:117 > - mode = "update" > + mode = "incremental" "incremental" is similar to the old update mode. In the future we can use the "fresh" method of the "full" mode to trigger clean builds on the bots if it necessary http://buildbot.net/buildbot/docs/0.8.6p1/manual/cfg-buildsteps.html#step-SVN
Csaba Osztrogonác
Comment 3 2012-06-27 07:15:32 PDT
(In reply to comment #2) > "incremental" is similar to the old update mode. Not similar, same. :) "This mode is exactly same as the old update mode."
Peter Gal
Comment 4 2012-06-28 00:57:04 PDT
(In reply to comment #1) > Created an attachment (id=149741) [details] > Patch Code looks sane to me.
Csaba Osztrogonác
Comment 5 2012-07-12 04:01:38 PDT
Comment on attachment 149741 [details] Patch It works more or less ... but there are some problems with master-side SVN step now: - It doesn't work with buildslave older than 0.8.5 because of an annoying bug. I already fixed it in the buildbot, so it will be in the next buildmaster release. - SVN revision isn't shown on the waterfall. I started experimenting with it, we can make it with a buildbot fix or a workaround in master.cfg. I'm on it.
Csaba Osztrogonác
Comment 6 2012-08-14 05:53:39 PDT
Created attachment 158307 [details] patch It depends on https://bugs.webkit.org/show_bug.cgi?id=85887 and fixes in buildbot, so I don't ask r? now.
Note You need to log in before you can comment on or make changes to this bug.