Bug 89967

Summary: [Platform] Change implementation of LocaleICU class to support more UDateFormat.
Product: WebKit Reporter: yosin
Component: PlatformAssignee: yosin
Status: RESOLVED FIXED    
Severity: Normal CC: tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 89965    
Attachments:
Description Flags
Patch 1
none
Patch 2 none

yosin
Reported 2012-06-26 03:11:02 PDT
For implementing input type "time", I would like to share code for time format with existing implementation.
Attachments
Patch 1 (8.00 KB, patch)
2012-06-26 18:29 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Patch 2 (8.02 KB, patch)
2012-06-26 21:59 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
yosin
Comment 1 2012-06-26 18:29:37 PDT
Created attachment 149658 [details] Patch 1
yosin
Comment 2 2012-06-26 18:29:59 PDT
Comment on attachment 149658 [details] Patch 1 Could you review this patch? Thanks in advance.
Kent Tamura
Comment 3 2012-06-26 21:29:00 PDT
Comment on attachment 149658 [details] Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=149658&action=review > Source/WebCore/ChangeLog:3 > + [Platform][DateTime][ICU] Change implementation of LocaleICU class to support more DateFormat. [DateTime] and [ICU] look redundant. What's 'DateFormat'? Do you mean 'UDateFormat'? > Source/WebCore/ChangeLog:8 > + This patch changes internal functions of LocalICU class to process LocalICU -> LocaleICU
yosin
Comment 4 2012-06-26 21:59:25 PDT
Created attachment 149676 [details] Patch 2
yosin
Comment 5 2012-06-26 22:01:39 PDT
Comment on attachment 149676 [details] Patch 2 Could you review again? Thanks in advance.
Kent Tamura
Comment 6 2012-06-26 23:00:55 PDT
Comment on attachment 149676 [details] Patch 2 Looks ok
yosin
Comment 7 2012-06-26 23:03:43 PDT
Comment on attachment 149676 [details] Patch 2 Clearing flags on attachment: 149676 Committed r121321: <http://trac.webkit.org/changeset/121321>
yosin
Comment 8 2012-06-26 23:03:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.