Bug 89552

Summary: [EFL][WK2] Add support for IMF composition
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, gyuyoung.kim, joone, lucas.de.marchi, rakuco, seokju.kwon, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP:basic implementation
none
Patch
none
Patch
none
Patch
none
Patch none

Ryuan Choi
Reported 2012-06-20 01:12:54 PDT
The WebKit2/Efl should support input method framework.
Attachments
WIP:basic implementation (25.68 KB, patch)
2012-09-21 00:19 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (26.50 KB, patch)
2012-10-04 18:57 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (26.46 KB, patch)
2012-10-04 19:15 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (27.15 KB, patch)
2012-10-09 19:44 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (27.28 KB, patch)
2012-10-22 21:50 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2012-09-21 00:19:25 PDT
Created attachment 165063 [details] WIP:basic implementation
Ryuan Choi
Comment 2 2012-09-21 00:20:43 PDT
Comment on attachment 165063 [details] WIP:basic implementation This should be cooked more.
Ryuan Choi
Comment 3 2012-10-04 18:57:16 PDT
Created attachment 167223 [details] Patch
Gyuyoung Kim
Comment 4 2012-10-04 19:04:53 PDT
Comment on attachment 167223 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167223&action=review > Source/WebKit2/PlatformEfl.cmake:204 > + ${ECORE_IMF_LIBRARIES} Wrong alphabetical order. > Source/WebKit2/UIProcess/API/efl/ewk_main.cpp:77 > + EINA_LOG_DOM_CRIT(_ewk_log_dom, "could not init ecore_imf."); ewk_private.h defined simple macros for this. Use CRITICAL macro. > Source/WebKit2/WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:56 > + // FIXME : sending sync message might make input lagging. FIXME : -> FIXME: > Source/WebKit2/WebProcess/WebPage/efl/WebPageEfl.cpp:176 > + } A new line ?
Ryuan Choi
Comment 5 2012-10-04 19:13:39 PDT
(In reply to comment #3) > Created an attachment (id=167223) [details] > Patch Rebased and added some comments. I was digging the issue which inserts preedit string two times when focus was moved. But, I realized that it is because of ecore_imf with xim. After tested using ecore_imf with scim (and scim-hangul - for korean), I it works logically.
Ryuan Choi
Comment 6 2012-10-04 19:15:41 PDT
Created attachment 167227 [details] Patch
Ryuan Choi
Comment 7 2012-10-04 19:51:05 PDT
(In reply to comment #4) > (From update of attachment 167223 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=167223&action=review > > > Source/WebKit2/PlatformEfl.cmake:204 > > + ${ECORE_IMF_LIBRARIES} > > Wrong alphabetical order. > Done. > > Source/WebKit2/UIProcess/API/efl/ewk_main.cpp:77 > > + EINA_LOG_DOM_CRIT(_ewk_log_dom, "could not init ecore_imf."); > > ewk_private.h defined simple macros for this. Use CRITICAL macro. > > > Source/WebKit2/WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:56 > > + // FIXME : sending sync message might make input lagging. > > FIXME : -> FIXME: Done. > > > Source/WebKit2/WebProcess/WebPage/efl/WebPageEfl.cpp:176 > > + } > > A new line ? Done. Thank you.
Ryuan Choi
Comment 8 2012-10-09 19:44:59 PDT
Created attachment 167898 [details] Patch
Ryuan Choi
Comment 9 2012-10-09 19:46:01 PDT
(In reply to comment #8) > Created an attachment (id=167898) [details] > Patch Rebased and fixed warning and bug which continues composition when clicked same input field.
Ryuan Choi
Comment 10 2012-10-22 21:50:03 PDT
Created attachment 170061 [details] Patch
Ryuan Choi
Comment 11 2012-10-22 21:50:43 PDT
(In reply to comment #10) > Created an attachment (id=170061) [details] > Patch just rebased.
Gyuyoung Kim
Comment 12 2012-10-23 04:21:44 PDT
Comment on attachment 170061 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170061&action=review > Source/WebKit2/WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:52 > + Frame* frame = m_page->corePage()->focusController()->focusedOrMainFrame(); Looks make sense. BTW, don't you need to move this to new function as mac port ?
Ryuan Choi
Comment 13 2012-10-23 05:26:15 PDT
(In reply to comment #12) > (From update of attachment 170061 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=170061&action=review > > > Source/WebKit2/WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:52 > > + Frame* frame = m_page->corePage()->focusController()->focusedOrMainFrame(); > > Looks make sense. BTW, don't you need to move this to new function as mac port ? IMO, current one looks enough until we have more requirements. Mac port has specific handleEditingKeyboardEvent for keyboardEvent and InputMethodKeydown. But, we share handleEditingKeyboardEvent with other ports and I think that this is simple.
WebKit Review Bot
Comment 14 2012-10-23 05:35:02 PDT
Comment on attachment 170061 [details] Patch Clearing flags on attachment: 170061 Committed r132210: <http://trac.webkit.org/changeset/132210>
WebKit Review Bot
Comment 15 2012-10-23 05:35:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.