Bug 89495

Summary: Web Inspector: Simplify InspectorIndexedDBAgent to use IDB metadata API
Product: WebKit Reporter: Joshua Bell <jsbell>
Component: Web Inspector (Deprecated)Assignee: Joshua Bell <jsbell>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, dgrogan, vsevik, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 88467    
Bug Blocks: 89701    
Attachments:
Description Flags
Patch
none
Patch none

Joshua Bell
Reported 2012-06-19 11:58:02 PDT
Right now the DatabaseLoaderCallback::execute() needs to grovel through IDB structures via transactions to gather the database schema (object stores, indexes). Once http://webkit.org/b/88467 lands this can be replaced with a call to idbDatabase->metadata() which will provide everything via simple structs.
Attachments
Patch (4.69 KB, patch)
2012-06-22 14:47 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Patch (4.70 KB, patch)
2012-06-22 15:38 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joshua Bell
Comment 1 2012-06-21 15:57:35 PDT
I can take this on, actually - I need to do it to unblock another patch I have in the works so I'll have this change locally already.
Joshua Bell
Comment 2 2012-06-22 14:47:12 PDT
Created attachment 149109 [details] Patch
Joshua Bell
Comment 3 2012-06-22 14:52:44 PDT
Comment on attachment 149109 [details] Patch Dropping review bit - won't pass until the dependent bug lands.
Joshua Bell
Comment 4 2012-06-22 15:38:53 PDT
Created attachment 149125 [details] Patch
Joshua Bell
Comment 5 2012-06-22 16:04:12 PDT
This can land now - vsevik@ - who'd be a good reviewer?
Vsevolod Vlasov
Comment 6 2012-06-24 06:17:50 PDT
Comment on attachment 149125 [details] Patch I am :)
WebKit Review Bot
Comment 7 2012-06-24 08:07:11 PDT
Comment on attachment 149125 [details] Patch Clearing flags on attachment: 149125 Committed r121117: <http://trac.webkit.org/changeset/121117>
WebKit Review Bot
Comment 8 2012-06-24 08:07:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.