Bug 89364

Summary: New inspector/styles/inject-stylesheet.html fails
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Alexander Pavlov (apavlov) <apavlov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, koivisto, ossy, zherczeg
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 87008, 89221    
Attachments:
Description Flags
Patch zherczeg: review+

Csaba Osztrogonác
Reported 2012-06-18 11:24:21 PDT
This test introdeuced in http://trac.webkit.org/changeset/120600 and fails at least on Qt and on Apple Mac Lion: --- /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/styles/inject-stylesheet-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/styles/inject-stylesheet-actual.txt @@ -1,82 +1,4 @@ -CONSOLE MESSAGE: line 9: iframe loaded Tests that injected user stylesheets are reflected in the Styles pane. +This test requires window.testRunner, exiting. -Main frame style: -[expanded] - -[expanded] -element.style { () - -======== Matched CSS Rules ======== -[expanded] -media="screen" (inject-stylesheet.html) -#main { (inject-stylesheet.html:5) -background: blue; - background-image: initial; - background-repeat-x: initial; - background-repeat-y: initial; - background-attachment: initial; - background-position-x: initial; - background-position-y: initial; - background-origin: initial; - background-clip: initial; - background-color: blue; - background-size: initial; - -[expanded] -#main { (user stylesheet) -color: red; - -[expanded] -div { (user agent stylesheet) -display: block; - - -iframe style: -[expanded] - -[expanded] -element.style { () - -======== Matched CSS Rules ======== -[expanded] -#iframebody { (user stylesheet) -background: red; - background-image: initial; - background-repeat-x: initial; - background-repeat-y: initial; - background-attachment: initial; - background-position-x: initial; - background-position-y: initial; - background-origin: initial; - background-clip: initial; - background-color: red; - background-size: initial; - -[expanded] -media="screen" (inject-stylesheet-iframe-data.html) -body { (inject-stylesheet-iframe-data.html:4) -background: green; - /-- overloaded --/ background-image: initial; - /-- overloaded --/ background-repeat-x: initial; - /-- overloaded --/ background-repeat-y: initial; - /-- overloaded --/ background-attachment: initial; - /-- overloaded --/ background-position-x: initial; - /-- overloaded --/ background-position-y: initial; - /-- overloaded --/ background-origin: initial; - /-- overloaded --/ background-clip: initial; - /-- overloaded --/ background-color: green; - /-- overloaded --/ background-size: initial; - -[expanded] -body { (user agent stylesheet) -display: block; -margin: 8px; - margin-top: 8px; - margin-right: 8px; - margin-bottom: 8px; - margin-left: 8px; - - -
Attachments
Patch (7.35 KB, patch)
2012-06-19 06:16 PDT, Alexander Pavlov (apavlov) 		zherczeg: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2012-06-18 11:39:32 PDT
I skipped it on Qt - r120610 to paint the bot green. Please unskip it with the proper fix.
Alexander Pavlov (apavlov)
Comment 2 2012-06-19 06:16:59 PDT
Created attachment 148321 [details] Patch
Csaba Osztrogonác
Comment 3 2012-06-19 06:57:01 PDT
I don't know inspector, so I'm not the best person for review. Maybe Zoltán? Otherwise I tested the patch and LayoutTests/inspector/styles/inject-stylesheet.html passes on Qt with it.
Zoltan Herczeg
Comment 4 2012-06-19 07:00:34 PDT
Comment on attachment 148321 [details] Patch LGTM
Alexander Pavlov (apavlov)
Comment 5 2012-06-19 07:03:30 PDT
Committed r120708: <http://trac.webkit.org/changeset/120708>
Note You need to log in before you can comment on or make changes to this bug.