Bug 89177

Summary: CompositeShadowTreeWalker should use InsertionPoint::hasDistribution instead of InsertionPoint::isActive
Product: WebKit Reporter: Hayato Ito <hayato>
Component: DOMAssignee: Hayato Ito <hayato>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dominicc, morrita, shinyak, tasak, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 78585, 89732    
Attachments:
Description Flags
fix none

Hayato Ito
Reported 2012-06-14 23:45:02 PDT
Currently, CompositeShadowTreeWalker uses InsertionPoint::isActive() to judge whether there are distributed nodes into the insertion point. But that is wrong. That should use InsertionPoint::hasDistribution() since InsertionPoint::isActive() return true when the insertion point which does not select any node and has fallback elements.
Attachments
fix (6.05 KB, patch)
2012-06-15 03:59 PDT, Hayato Ito 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hayato Ito
Comment 1 2012-06-15 00:05:37 PDT
WONTFIX. CompositeShadowTreeWalker is innocent.
Hayato Ito
Comment 2 2012-06-15 03:33:40 PDT
Reopened. ComposedShadowTreeWalker wrongly traverses nodes in the following case: <div> #shadow-root <content> <div id=fallback> <div id=distributed-node> If ComposendShadowTreeWalker traverses this tree, starting with #fallback element, it wrongly *escapes* out of the parent <content> element. Since a #fallback element is not used in composed shadow dom tree, it should be treated as orphaned subtree.
Hayato Ito
Comment 3 2012-06-15 03:59:20 PDT
Created attachment 147789 [details] fix
WebKit Review Bot
Comment 4 2012-06-28 16:06:15 PDT
Comment on attachment 147789 [details] fix Clearing flags on attachment: 147789 Committed r121481: <http://trac.webkit.org/changeset/121481>
WebKit Review Bot
Comment 5 2012-06-28 16:06:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.