Bug 89093

Summary: Remove volume thumb for videos without audio track for Chrome Video controls
Product: WebKit Reporter: Silvia Pfeiffer <silviapf>
Component: MediaAssignee: Silvia Pfeiffer <silviapf>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, eric.carlson, eric, feature-media-reviews, macpherson, menard, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 84672, 89050    
Attachments:
Description Flags
complete patch for linux-ews layout tests
none
Use this for review
none
patch for cq - also includes image change for elements without audio none

Silvia Pfeiffer
Reported 2012-06-14 06:26:33 PDT
This patch is part of the introduction of the new Chromium video controls, master bug at https://bugs.webkit.org/show_bug.cgi?id=84672 . It removes the volume thumb for video and audio elements that have no audio track or have no media resource.
Attachments
complete patch for linux-ews layout tests (25.34 KB, patch)
2012-06-14 06:31 PDT, Silvia Pfeiffer 		no flags
DetailsFormatted DiffDiff
Use this for review (6.57 KB, patch)
2012-06-14 06:32 PDT, Silvia Pfeiffer 		no flags
DetailsFormatted DiffDiff
patch for cq - also includes image change for elements without audio (4.11 KB, patch)
2012-06-14 19:26 PDT, Silvia Pfeiffer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Silvia Pfeiffer
Comment 1 2012-06-14 06:31:46 PDT
Created attachment 147571 [details] complete patch for linux-ews layout tests
Silvia Pfeiffer
Comment 2 2012-06-14 06:32:57 PDT
Created attachment 147572 [details] Use this for review
Eric Carlson
Comment 3 2012-06-14 09:49:32 PDT
Comment on attachment 147572 [details] Use this for review View in context: https://bugs.webkit.org/attachment.cgi?id=147572&action=review Looks fine except for the ChangeLog. > Source/WebCore/ChangeLog:7 > 2012-06-14 Silvia Pfeiffer <silviapf@chromium.org> > > - Add fullscreen button to Chrome video controls for video. > - https://bugs.webkit.org/show_bug.cgi?id=88818 > + Remove volume thumb for videos without audio track. > + https://bugs.webkit.org/show_bug.cgi?id=89093 > > Reviewed by NOBODY (OOPS!). > Clearly something went wrong when this ChangeLog was generated :-)
Silvia Pfeiffer
Comment 4 2012-06-14 19:26:32 PDT
Created attachment 147711 [details] patch for cq - also includes image change for elements without audio
WebKit Review Bot
Comment 5 2012-06-15 11:00:05 PDT
Comment on attachment 147711 [details] patch for cq - also includes image change for elements without audio Clearing flags on attachment: 147711 Committed r120478: <http://trac.webkit.org/changeset/120478>
WebKit Review Bot
Comment 6 2012-06-15 11:00:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.