Bug 89090

Summary: Change CSS for range sliders in Chrome video controls
Product: WebKit Reporter: Silvia Pfeiffer <silviapf>
Component: MediaAssignee: Silvia Pfeiffer <silviapf>
Status: NEW    
Severity: Normal CC: ahmad.saleem792, cmarcelo, eric.carlson, feature-media-reviews, macpherson, menard, thorton, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch for review none

Silvia Pfeiffer
Reported 2012-06-14 04:50:51 PDT
Bug 62218 fixed the addressing of shadow doms in shadow doms with CSS. This should be taken advantage of in the CSS file for the Chrome video player as committed in bug 88623.
Attachments
patch for review (8.03 KB, patch)
2012-06-18 23:44 PDT, Silvia Pfeiffer 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Silvia Pfeiffer
Comment 1 2012-06-18 23:44:27 PDT
Created attachment 148265 [details] patch for review
Silvia Pfeiffer
Comment 2 2012-06-19 05:28:03 PDT
This removes a "FIXME" from the codebase.
Eric Carlson
Comment 3 2012-06-19 10:14:40 PDT
Bug 62218 was fixed on June 12, but the "-webkit-media-slider-container" rules were added to html.css on June 18 to fix bug 89280. Won't this patch break the Mac port again?
Silvia Pfeiffer
Comment 4 2012-06-19 13:37:51 PDT
As long as there is no other private codebase that now depends on -webkit-media-slider-* rules, it shouldn't break any ports. It completely removes all -webkit-media-slider-* rules, including the one from html.css . This was not possible before which is why I introduced the FIXME. This resets it to the way things worked before for all ports.
Silvia Pfeiffer
Comment 5 2012-06-20 22:59:26 PDT
Comment on attachment 148265 [details] patch for review Need to check if it will cause new regressions on other ports first.
Silvia Pfeiffer
Comment 6 2012-06-25 21:05:58 PDT
Don't forget to include change to android css styling rule: https://bugs.webkit.org/show_bug.cgi?id=89910
Ahmad Saleem
Comment 7 2023-12-09 06:33:23 PST
Do we need this or is applicable to only 'Chromium' port. While looking into 'html.css', we do have: input[type="range"]::-webkit-slider-container, input[type="range"]::-webkit-media-slider-container instead of proposed in the patch: input[type="range"]::-webkit-slider-container { ___ Just wanted to confirm.
Note You need to log in before you can comment on or make changes to this bug.