Bug 88944

Summary: nrwt: restructure the port classes to handle multiple expectations files
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, ojan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 88942    
Bug Blocks: 65834, 88946    
Attachments:
Description Flags
Patch ojan: review+

Dirk Pranke
Reported 2012-06-12 19:21:17 PDT
nrwt: restructure the port classes to handle multiple expectations files
Attachments
Patch (23.58 KB, patch)
2012-06-12 19:26 PDT, Dirk Pranke 		ojan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-06-12 19:26:36 PDT
Created attachment 147215 [details] Patch
Ojan Vafai
Comment 2 2012-06-13 09:30:05 PDT
Comment on attachment 147215 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147215&action=review > Tools/Scripts/webkitpy/layout_tests/port/base.py:924 > + def test_expectations(self): Add a FIXME to remove this? > Tools/Scripts/webkitpy/layout_tests/port/base.py:931 > def test_expectations_overrides(self): Add a FIXME to remove this?
Dirk Pranke
Comment 3 2012-06-13 10:19:34 PDT
Will do. Obviously, they get removed later in this series of patches, but better to be safe in the meantime.
Dirk Pranke
Comment 4 2012-06-13 12:40:59 PDT
Committed r120236: <http://trac.webkit.org/changeset/120236>
Note You need to log in before you can comment on or make changes to this bug.