Bug 88880

Summary: [Qt][Win]Debug build of WebKit can't find debug-named versions of the static libraries
Product: WebKit Reporter: Joel Dillon <joel.dillon>
Component: New BugsAssignee: Jocelyn Turcotte <jturcotte>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, jturcotte, vestbo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 88300    
Attachments:
Description Flags
Patch vestbo: review+

Joel Dillon
Reported 2012-06-12 09:10:50 PDT
For some reason when doing a debug build, the static libraries aren't referenced by their correct names on Windows (JavaScriptCored.lib vs JavaScriptCore, for example) when building the dll. Symptoms are errors such as: NMAKE : fatal error U1073: don't know how to make 'c:\Users\Joel\dev\qt5\qtwebkit\WebKitBuild\Debug\Source\WebCore\release\WebCore.lib' I presume the solution is $$qtLibraryTarget() inserted at a suitable place, but I do not know where that place is.
Attachments
Patch (1.87 KB, patch)
2012-06-13 09:32 PDT, Jocelyn Turcotte 		vestbo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jocelyn Turcotte
Comment 1 2012-06-13 09:32:54 PDT
Created attachment 147339 [details] Patch
Simon Hausmann
Comment 2 2012-06-18 07:45:05 PDT
I recall seeing this patch on your screen :).
Simon Hausmann
Comment 3 2012-06-19 00:33:32 PDT
Committed r120685: <http://trac.webkit.org/changeset/120685>
Note You need to log in before you can comment on or make changes to this bug.