Bug 88768

Summary: Validate form state strings in FormController::setStateForNewFormElements()
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, gustavo, haraken, japhet, jochen, morrita, ojan, philn, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 89070    
Bug Blocks: 23346    
Attachments:
Description Flags
WIP
none
WIP 2
none
WIP 3
none
WIP 4
none
Patch
none
Archive of layout-test-results from ec2-cr-linux-01
none
Patch 2
none
Patch 3 morrita: review+, morrita: commit-queue-

Kent Tamura
Reported 2012-06-11 01:04:42 PDT
Validate form state strings in FormController::setStateForNewFormElements()
Attachments
WIP (18.68 KB, patch)
2012-06-14 00:30 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
WIP 2 (24.93 KB, patch)
2012-06-14 04:36 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
WIP 3 (24.73 KB, patch)
2012-06-14 04:52 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
WIP 4 (24.76 KB, patch)
2012-06-14 05:11 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch (26.84 KB, patch)
2012-06-14 05:23 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ec2-cr-linux-01 (623.45 KB, application/zip)
2012-06-14 10:53 PDT, WebKit Review Bot 		no flags
Details
Patch 2 (26.84 KB, patch)
2012-06-14 17:43 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch 3 (25.29 KB, patch)
2012-06-14 19:29 PDT, Kent Tamura 		morrita: review+
morrita: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-06-14 00:30:29 PDT
Created attachment 147508 [details] WIP
Build Bot
Comment 2 2012-06-14 01:09:31 PDT
Comment on attachment 147508 [details] WIP Attachment 147508 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12952487
Kent Tamura
Comment 3 2012-06-14 04:36:28 PDT
Created attachment 147553 [details] WIP 2
Gustavo Noronha (kov)
Comment 4 2012-06-14 04:47:31 PDT
Comment on attachment 147553 [details] WIP 2 Attachment 147553 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12955365
Kent Tamura
Comment 5 2012-06-14 04:52:06 PDT
Created attachment 147555 [details] WIP 3
Gustavo Noronha (kov)
Comment 6 2012-06-14 05:05:26 PDT
Comment on attachment 147555 [details] WIP 3 Attachment 147555 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12954375
Kent Tamura
Comment 7 2012-06-14 05:11:29 PDT
Created attachment 147559 [details] WIP 4
Kent Tamura
Comment 8 2012-06-14 05:23:07 PDT
Created attachment 147561 [details] Patch
WebKit Review Bot
Comment 9 2012-06-14 10:53:33 PDT
Comment on attachment 147561 [details] Patch Attachment 147561 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12965227 New failing tests: fast/forms/state-restore-broken-state.html
WebKit Review Bot
Comment 10 2012-06-14 10:53:38 PDT
Created attachment 147616 [details] Archive of layout-test-results from ec2-cr-linux-01 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Kent Tamura
Comment 11 2012-06-14 17:43:22 PDT
Created attachment 147692 [details] Patch 2 Fix the test result
Kent Tamura
Comment 12 2012-06-14 19:29:42 PDT
Created attachment 147713 [details] Patch 3 Remove binding code
Hajime Morrita
Comment 13 2012-06-14 21:22:59 PDT
Comment on attachment 147713 [details] Patch 3 View in context: https://bugs.webkit.org/attachment.cgi?id=147713&action=review > Source/WebCore/ChangeLog:11 > + - A future versio of WebKit might change the format Typo: versio
Kent Tamura
Comment 14 2012-06-14 21:34:41 PDT
Committed r120397: <http://trac.webkit.org/changeset/120397>
Note You need to log in before you can comment on or make changes to this bug.