Bug 88761

Summary: Use testRunner instead of layoutTestController in battery status and canvas tests
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: New BugsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, kbr, kenneth, kihong.kwon, kling, krit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 88210    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch tony: review+

Ryosuke Niwa
Reported 2012-06-11 00:22:53 PDT
Use testRunner instead of layoutTestController in battery status and canvas tests
Attachments
Patch (2.59 KB, patch)
2012-06-11 00:28 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch (4.08 KB, patch)
2012-06-11 00:30 PDT, Ryosuke Niwa 		tony: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-06-11 00:28:30 PDT
Created attachment 146799 [details] Patch
Ryosuke Niwa
Comment 2 2012-06-11 00:30:37 PDT
Created attachment 146800 [details] Patch
Ryosuke Niwa
Comment 3 2012-06-11 00:34:10 PDT
Ran: find LayoutTests/batterystatus/ LayoutTests/platform/*/batterystatus/ -type f -not -iwholename "*.svn*" -not -name "*.png" -not -name "*.ttf" -not -name "*.gif" | xargs sed -i -e "s/layoutTestController/testRunner/g" find LayoutTests/canvas/ LayoutTests/platform/*/canvas/ -type f -not -iwholename "*.svn*" -not -name "*.png" -not -name "*.ttf" -not -name "*.gif" | xargs sed -i -e "s/layoutTestController/testRunner/g"
Tony Chang
Comment 4 2012-06-11 10:13:05 PDT
Comment on attachment 146800 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146800&action=review > LayoutTests/canvas/philip/tests/2d.text-custom-font-load-crash.html:30 > }), 500); This timeout is unfortunate, but unrelated to your patch.
Ryosuke Niwa
Comment 5 2012-06-14 23:23:27 PDT
Committed r120407: <http://trac.webkit.org/changeset/120407>
Note You need to log in before you can comment on or make changes to this bug.