Bug 88626

Summary: Add app_abi option for DumpRenderTree_apk
Product: WebKit Reporter: Wei James (wistoch) <james.wei>
Component: New BugsAssignee: Wei James (wistoch) <james.wei>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, jrg, peter, tony, wangxianzhu, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Android   
OS: Android   
Bug Depends on:    
Bug Blocks: 88658    
Attachments:
Description Flags
Patch
none
Patch none

Wei James (wistoch)
Reported 2012-06-07 23:30:30 PDT
Add app_abi option for DumpRenderTree_apk
Attachments
Patch (1.32 KB, patch)
2012-06-07 23:30 PDT, Wei James (wistoch) 		no flags
DetailsFormatted DiffDiff
Patch (1.35 KB, patch)
2012-06-08 08:33 PDT, Wei James (wistoch) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wei James (wistoch)
Comment 1 2012-06-07 23:30:58 PDT
Created attachment 146489 [details] Patch
Peter Beverloo
Comment 2 2012-06-08 07:59:19 PDT
Comment on attachment 146489 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146489&action=review LGTM from for Android's perspective, but please wait for a reviewer before submitting. Do you think it'd be useful to file a meta bug tracking changes you make to WebKit for supporting Android x86? It's great work! > Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:443 > + '--app_abi=<(android_app_abi)' One nit: I'd prefer to stay in line with other arguments passed to generate_native_test.py (with the exception of -DPRODUCT_DIR) and have the argument's name and value on separate lines. - '--app_abi=<(android_app_abi)' + '--app_abi', + '<(android_app_abi)',
Wei James (wistoch)
Comment 3 2012-06-08 08:33:46 PDT
Created attachment 146577 [details] Patch
Wei James (wistoch)
Comment 4 2012-06-08 08:35:29 PDT
Comment on attachment 146489 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146489&action=review >> Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:443 >> + '--app_abi=<(android_app_abi)' > > One nit: I'd prefer to stay in line with other arguments passed to generate_native_test.py (with the exception of -DPRODUCT_DIR) and have the argument's name and value on separate lines. > > - '--app_abi=<(android_app_abi)' > + '--app_abi', > + '<(android_app_abi)', fixed.thanks for the reviewing.
Wei James (wistoch)
Comment 5 2012-06-08 08:37:37 PDT
(In reply to comment #2) > Do you think it'd be useful to file a meta bug tracking changes you make to WebKit for supporting Android x86? It's great work! > Good idea. Although I don't know how many patches needed to enable android x86, it is useful to file a meta bug to track all the bugs.
Peter Beverloo
Comment 6 2012-06-08 08:45:29 PDT
(In reply to comment #5) > Good idea. Although I don't know how many patches needed to enable android x86, it is useful to file a meta bug to track all the bugs. It'd be good for the general overview. Thank you very much! LGTM. Could a reviewer have a formal look, please?
Adam Barth
Comment 7 2012-06-08 11:31:49 PDT
Comment on attachment 146577 [details] Patch rs=me
WebKit Review Bot
Comment 8 2012-06-08 11:44:54 PDT
Comment on attachment 146577 [details] Patch Clearing flags on attachment: 146577 Committed r119851: <http://trac.webkit.org/changeset/119851>
WebKit Review Bot
Comment 9 2012-06-08 11:44:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.