Bug 88529

Created attachment 146266 [details] ROLLOUT of r119694 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.

Comment on attachment 146266 [details] ROLLOUT of r119694 Clearing flags on attachment: 146266 Committed r119712: <http://trac.webkit.org/changeset/119712>

All reviewed patches have been landed. Closing bug.

It is failing on mac & linux the log: ALSA lib confmisc.c:768:(parse_card) cannot find card '0' ALSA lib conf.c:4154:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings ALSA lib conf.c:4154:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name ALSA lib conf.c:4154:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:4633:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2211:(snd_pcm_open_noupdate) Unknown PCM default [23410:23423:0607/052914:5557937382:WARNING:alsa_util.cc(24)] PcmOpen: default,No such file or directory ALSA lib confmisc.c:768:(parse_card) cannot find card '0' ALSA lib conf.c:4154:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings ALSA lib conf.c:4154:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name ALSA lib conf.c:4154:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:4633:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2211:(snd_pcm_open_noupdate) Unknown PCM default [23410:23423:0607/052914:5557937552:WARNING:alsa_util.cc(24)] PcmOpen: plug:default,No such file or directory chrome/browser/prerender/prerender_browsertest.cc:162: Failure Value of: final_status() Actual: 1 Expected: expected_final_status_ Which is: 0 when testing URL /files/prerender/prerender_html5_video_network.html (Expected: Used, Actual: Timed Out) chrome/browser/prerender/prerender_browsertest.cc:256: Failure Value of: ready_title_watcher_->WaitAndGetTitle() Actual: Expected: ready_title Which is: READY base::debug::StackTrace::StackTrace() [0x12416ce] base::(anonymous namespace)::StackDumpSignalHandler() [0x1277b59] 0x7fb0ef6e6af0 ui_test_utils::(anonymous namespace)::ExecuteJavaScriptHelper() [0x122e094] ui_test_utils::ExecuteJavaScriptAndExtractBool() [0x122e530] prerender::PrerenderBrowserTest::PrerenderTestURLImpl() [0x669bbc] prerender::PrerenderBrowserTest_PrerenderHTML5VideoNetwork_Test::RunTestOnMainThread() [0x6736fb] InProcessBrowserTest::RunTestOnMainThreadLoop() [0x1223359] ChromeBrowserMainParts::PreMainMessageLoopRunImpl() [0x329f579] ChromeBrowserMainParts::PreMainMessageLoopRun() [0x329ffee] content::BrowserMainLoop::CreateThreads() [0x2cbd441] (anonymous namespace)::BrowserMainRunnerImpl::Initialize() [0x2dd3cc9] BrowserMain() [0x36d03f7] BrowserTestBase::SetUp() [0x31daa6c] InProcessBrowserTest::SetUp() [0x1223d38] testing::Test::Run() [0x154e772] testing::TestInfo::Run() [0x154e8ca] testing::TestCase::Run() [0x154ea17] testing::internal::UnitTestImpl::RunAllTests() [0x154ecbd] testing::UnitTest::Run() [0x154d703] base::TestSuite::Run() [0x12b28d8] ChromeTestLauncherDelegate::RunTestSuite() [0x8a91ce] test_launcher::LaunchTests() [0x9832f4] main [0x8a9239] 0x7fb0ef6d1c4d 0x43b3b9

What is "PrerenderBrowserTest.PrerenderHTML5VideoNetwork" and how can we make sure a patch doesn't break it?

(In reply to comment #5) > What is "PrerenderBrowserTest.PrerenderHTML5VideoNetwork" It's a chromium unit test (in the browser_tests suite). > and how can we make sure a patch doesn't break it? I don't know. Given the webkit bots/EWS/CQ can't run chromium's entire test collection (which can take hours), I'm surprised that a single chromium test failure is sufficient grounds to roll out a webkit change.

(In reply to comment #6) > (In reply to comment #5) > > What is "PrerenderBrowserTest.PrerenderHTML5VideoNetwork" > > It's a chromium unit test (in the browser_tests suite). > Thanks. > > and how can we make sure a patch doesn't break it? > > I don't know. Given the webkit bots/EWS/CQ can't run chromium's entire test collection (which can take hours), I'm surprised that a single chromium test failure is sufficient grounds to roll out a webkit change. > I strongly agree! @loislo, what was the rational for rolling out this patch?

I made WebKit roll for solving a problem with chromeos bot and found that the test started to fail in chromium tree. Unfortunately I had not enough time for deep investigation. I'm sorry. fishcman and abarth were offline at the moment. I saw that the patch was related to chromium. Then I decided that the working test and the reverted patch are better than the disabled test and landed patch. It was single test but it was crashed on tha all platforms. Personally I'm not using webkit commit queue even for Web Inspector patches because it can break the build when I'm away. Chromium people can use try bots farm for testing chromium and webkit patches. (In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #5) > > > What is "PrerenderBrowserTest.PrerenderHTML5VideoNetwork" > > > > It's a chromium unit test (in the browser_tests suite). > > > Thanks. > > > > and how can we make sure a patch doesn't break it? > > > > I don't know. Given the webkit bots/EWS/CQ can't run chromium's entire test collection (which can take hours), I'm surprised that a single chromium test failure is sufficient grounds to roll out a webkit change. > > > I strongly agree! @loislo, what was the rational for rolling out this patch?