Bug 88302

Summary:

[Qt][Win] Fix linking WTF with ICU

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

Tools / Tests

Assignee:

Csaba Osztrogonác <ossy>

Status:

RESOLVED FIXED

Severity:

Blocker

CC:

ossy

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

Attachments:

Description	Flags
Patch	none

Csaba Osztrogonác

Reported 2012-06-05 01:03:04 PDT

Linking WTF fails because of missing ICU libraries. (It seems the lib names are different on Windows.)

Attachments
Patch (1.17 KB, patch) 2012-06-05 05:33 PDT, Csaba Osztrogonác	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Csaba Osztrogonác

Comment 1 2012-06-05 05:33:09 PDT

Simon Hausmann

Comment 2 2012-06-05 14:31:59 PDT

Comment on attachment 145768 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145768&action=review > Source/WTF/WTF.pri:30 > + win32-*: LIBS += -licuin -licuuc -licudt I think that you can just use win32 instead of win32-*. The former is also what we use in Qt.

Csaba Osztrogonác

Comment 3 2012-06-07 04:40:47 PDT

(In reply to comment #2) > (From update of attachment 145768 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=145768&action=review > > > Source/WTF/WTF.pri:30 > > + win32-*: LIBS += -licuin -licuuc -licudt > > I think that you can just use win32 instead of win32-*. The former is also what we use in Qt. Good point. Fixed patch landed in http://trac.webkit.org/changeset/119704

Note You need to log in before you can comment on or make changes to this bug.