Bug 88026

Summary:

[Wk2] Support input element time

Product:

WebKit

Reporter:

Dinu Jacob <dinu.jacob>

Component:

WebKit2

Assignee:

Dinu Jacob <dinu.jacob>

Status:

NEW

Severity:

Normal

CC:

andymark449, anisimran166, ap, cmarcelo, digitaltrendstech1, irfaan4a, jackace334, japhet, jochen, mcraedavid382, menard, m.goleb+bugzilla, mkhatib727, rajsnh200, ravic9107, shaniyadav929, technipak45, vihaanchauhan8443, webkit.review.bot, yosin, zoltan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

86990

Bug Blocks:

88933

Attachments:

Description	Flags
First patch	tkent: review-, buildbot: commit-queue-

Dinu Jacob

Reported 2012-05-31 17:05:49 PDT

Add suuport for <input type="time">

Attachments
First patch (38.26 KB, patch) 2012-06-12 16:24 PDT, Dinu Jacob	tkent: review- buildbot: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dinu Jacob

Comment 1 2012-06-12 16:24:43 PDT

Created attachment 147186 [details] First patch

Build Bot

Comment 2 2012-06-12 16:54:34 PDT

Comment on attachment 147186 [details] First patch Attachment 147186 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12939855

Kent Tamura

Comment 3 2012-06-13 00:21:37 PDT

(In reply to comment #1) > Created an attachment (id=147186) [details] > First patch What do you think about UI in a page? How does a user invoke TimeChooser?

yosin

Comment 4 2012-06-13 00:25:24 PDT

Please use ENABLE_TIME_CHOOSER for enabling this feature. Some port, e.g. Android, enables ENABLE_TIME_INPUT but they may not want to use time chooser.

yosin

Comment 5 2012-06-13 00:26:40 PDT

(In reply to comment #4) > Please use ENABLE_TIME_CHOOSER for enabling this feature. > Some port, e.g. Android, enables ENABLE_TIME_INPUT but they may not want to use time chooser. There is an ENABLE_CALENDAR_PICKER used in WebCore/html/DateInputType.cpp

Dinu Jacob

Comment 6 2012-06-13 06:57:43 PDT

I was thinking of modeling it on color chooser implementation (haven't uploaded a patch but have it on my branch). But when I saw the bug that Yosin was working, wanted to wait for that before proceeding with that.

Dinu Jacob

Comment 7 2012-06-13 06:57:58 PDT

(In reply to comment #3) > (In reply to comment #1) > > Created an attachment (id=147186) [details] [details] > > First patch > > What do you think about UI in a page? How does a user invoke TimeChooser? I was thinking of modeling it on color chooser implementation (haven't uploaded a patch but have it on my branch). But when I saw the bug that Yosin was working, wanted to wait for that before proceeding with that.

Dinu Jacob

Comment 8 2012-06-13 17:00:24 PDT

(In reply to comment #5) > (In reply to comment #4) > > Please use ENABLE_TIME_CHOOSER for enabling this feature. > > Some port, e.g. Android, enables ENABLE_TIME_INPUT but they may not want to use time chooser. > > There is an ENABLE_CALENDAR_PICKER used in WebCore/html/DateInputType.cpp If I am understanding it correctly, you are suggesting that this feature that delegates the UI to the client in another flag similar to CALENDAR_PICKER?

Dinu Jacob

Comment 9 2012-06-13 18:01:59 PDT

(In reply to comment #8) > (In reply to comment #5) > > (In reply to comment #4) > > > Please use ENABLE_TIME_CHOOSER for enabling this feature. > > > Some port, e.g. Android, enables ENABLE_TIME_INPUT but they may not want to use time chooser. > > > > There is an ENABLE_CALENDAR_PICKER used in WebCore/html/DateInputType.cpp > > If I am understanding it correctly, you are suggesting that this feature that delegates the UI to the client in another flag similar to CALENDAR_PICKER? I meant be * be wrapped * in another flag

yosin

Comment 10 2012-06-13 18:14:08 PDT

(In reply to comment #9) > (In reply to comment #8) > > (In reply to comment #5) > > > (In reply to comment #4) > > > > Please use ENABLE_TIME_CHOOSER for enabling this feature. > > > > Some port, e.g. Android, enables ENABLE_TIME_INPUT but they may not want to use time chooser. > > > > > > There is an ENABLE_CALENDAR_PICKER used in WebCore/html/DateInputType.cpp > > > > If I am understanding it correctly, you are suggesting that this feature that delegates the UI to the client in another flag similar to CALENDAR_PICKER? > > I meant be * be wrapped * in another flag Yes, please use another flag something like ENABLE_TIME_PICKER, or another appropriate one.

Kent Tamura

Comment 11 2012-06-13 21:11:10 PDT

For desktop browsers, inline editing UI which yosin is working on is enough and picker dialog UI would be unnecessary (or optional). On the other hand, we want picker dialog UI for mobile browsers, and no inline editing UI. iOS and Chromium/Android have picker dialog UI for date/time types. So, both of inline editing UI and picker dialog UI should have their own ENABLE flags. I think we can make generic API of picker dialog UI for all of date/time types. We currently have PAGE_POPUP API in ChromeClient for CALENDAR_PICKER, however we might able to change CALENDAR_PICKER so that it uses the generic API and PAGE_POPUP API is one of implementations of the generic API.

Kent Tamura

Comment 12 2012-11-09 00:29:46 PST

Comment on attachment 147186 [details] First patch Please apply * ENABLE_INPUT_MULTIPLE_FIELDS_UI or * No ENABLE_INPUT_MULTIPLE_FIELDS, and support ChromeClient::openDateTimeChooser

Note You need to log in before you can comment on or make changes to this bug.