Bug 87893

Summary:

[Chromium] Chromium DRT should be able to load external resources

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Tools / Tests

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dglazkov, dpranke, haraken, morrita, ojan, tkent, tony, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

84008

Attachments:

Description	Flags
Adds the feature	none
Removed replay test changes in webkitpy	dpranke: review+, rniwa: commit-queue-
Archive of layout-test-results from ec2-cr-linux-01	none

Ryosuke Niwa

Reported 2012-05-30 13:31:32 PDT

For relay performance tests, we need DRT to be loading external resources.

Attachments
Adds the feature (15.81 KB, patch) 2012-05-30 13:41 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Removed replay test changes in webkitpy (3.29 KB, patch) 2012-05-30 13:44 PDT, Ryosuke Niwa	dpranke: review+ rniwa: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cr-linux-01 (569.05 KB, application/zip) 2012-05-30 19:36 PDT, WebKit Review Bot	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2012-05-30 13:41:53 PDT

Created attachment 144913 [details] Adds the feature

Ryosuke Niwa

Comment 2 2012-05-30 13:44:11 PDT

Created attachment 144915 [details] Removed replay test changes in webkitpy

Dirk Pranke

Comment 3 2012-05-30 13:46:34 PDT

Comment on attachment 144915 [details] Removed replay test changes in webkitpy Hm. I thought this was already supported behind a flag or something, but I guess not. Looks fine to me.

WebKit Review Bot

Comment 4 2012-05-30 13:47:15 PDT

Attachment 144915 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/DumpRenderTree/c..." exit_code: 1 Tools/DumpRenderTree/chromium/WebViewHost.cpp:1209: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Ryosuke Niwa

Comment 5 2012-05-30 14:57:37 PDT

Comment on attachment 144915 [details] Removed replay test changes in webkitpy View in context: https://bugs.webkit.org/attachment.cgi?id=144915&action=review >> Tools/DumpRenderTree/chromium/WebViewHost.cpp:1209 >> +static void blockRequest(WebURLRequest& request) { > > Place brace on its own line for function definitions. [whitespace/braces] [4] Oops, will fix.

Kent Tamura

Comment 6 2012-05-30 15:02:19 PDT

Comment on attachment 144915 [details] Removed replay test changes in webkitpy View in context: https://bugs.webkit.org/attachment.cgi?id=144915&action=review > Tools/DumpRenderTree/chromium/WebViewHost.cpp:-1248 > - && !m_shell->allowExternalPages()) { So, we can remove TestShell::allowExternalPages() ?

Ryosuke Niwa

Comment 7 2012-05-30 15:03:53 PDT

Comment on attachment 144915 [details] Removed replay test changes in webkitpy View in context: https://bugs.webkit.org/attachment.cgi?id=144915&action=review >> Tools/DumpRenderTree/chromium/WebViewHost.cpp:-1248 >> - && !m_shell->allowExternalPages()) { > > So, we can remove TestShell::allowExternalPages() ? Oh oops, I forgot to add that condition :( Will fix.

WebKit Review Bot

Comment 8 2012-05-30 19:36:44 PDT

Comment on attachment 144915 [details] Removed replay test changes in webkitpy Attachment 144915 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12865086 New failing tests: fast/ruby/generated-before-counter-doesnt-crash.html fast/loader/null-request-after-willSendRequest.html fast/css-generated-content/malformed-url.html fast/loader/javascript-url-iframe-remove-on-navigate.html fast/ruby/before-table-doesnt-crash.html svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg fast/ruby/before-block-doesnt-crash.html

WebKit Review Bot

Comment 9 2012-05-30 19:36:48 PDT

Created attachment 144972 [details] Archive of layout-test-results from ec2-cr-linux-01 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Ryosuke Niwa

Comment 10 2012-05-31 14:51:14 PDT

Committed r119153: <http://trac.webkit.org/changeset/119153>

Note You need to log in before you can comment on or make changes to this bug.