Bug 87830

Summary: Web Inspector: add MemoryUsageSupport::processMemoryUsageBytes
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, dglazkov, fishd, jamesr, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, tkent+wkapi, tony, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 80787    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch jamesr: review+

Yury Semikhatsky
Reported 2012-05-30 00:26:33 PDT
We need to know process memory usage to show it in the inspector. It is now exposed on Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h which is Chromium-specific file. We need a more portable approach here.
Attachments
Patch (8.61 KB, patch)
2012-05-30 00:32 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch (8.63 KB, patch)
2012-05-30 00:38 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch (8.63 KB, patch)
2012-05-30 01:03 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch (8.61 KB, patch)
2012-05-30 02:16 PDT, Yury Semikhatsky 		jamesr: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2012-05-30 00:32:27 PDT
Created attachment 144735 [details] Patch
Yury Semikhatsky
Comment 2 2012-05-30 00:33:04 PDT
(In reply to comment #1) > Created an attachment (id=144735) [details] > Patch This patch addresses Tony's comments on http://codereview.chromium.org/9669039/diff/5/webkit/glue/webkitplatformsupport_impl.h
WebKit Review Bot
Comment 3 2012-05-30 00:35:55 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Yury Semikhatsky
Comment 4 2012-05-30 00:38:21 PDT
Created attachment 144736 [details] Patch
Yury Semikhatsky
Comment 5 2012-05-30 01:03:25 PDT
Created attachment 144742 [details] Patch
Build Bot
Comment 6 2012-05-30 01:32:04 PDT
Comment on attachment 144742 [details] Patch Attachment 144742 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12843770
Yury Semikhatsky
Comment 7 2012-05-30 02:16:10 PDT
Created attachment 144759 [details] Patch
James Robinson
Comment 8 2012-05-30 09:44:08 PDT
Comment on attachment 144759 [details] Patch Seems pretty reasonable to me
Adam Barth
Comment 9 2012-05-30 11:32:10 PDT
Comment on attachment 144759 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144759&action=review > Source/WebCore/inspector/InspectorMemoryAgent.cpp:-342 > -#if PLATFORM(CHROMIUM) Yay removing #if CHROMIUM
Yury Semikhatsky
Comment 10 2012-05-31 00:33:36 PDT
Committed r119068: <http://trac.webkit.org/changeset/119068>
Note You need to log in before you can comment on or make changes to this bug.