Bug 87251

Summary: [EFL][CMake] Integrate API unit tests with CTest
Product: WebKit Reporter: Thiago Marcos P. Santos <tmpsantos>
Component: WebKit EFLAssignee: Thiago Marcos P. Santos <tmpsantos>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dbates, dglazkov, gyuyoung.kim, jochen, k.czech, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 68509    
Bug Blocks: 86092, 87252    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from gce-cr-linux-08
none
Patch none

Thiago Marcos P. Santos
Reported 2012-05-23 05:04:28 PDT
CMake provides a nice built-in test runner that we should make use of it.
Attachments
Patch (2.82 KB, patch)
2012-07-02 05:25 PDT, Thiago Marcos P. Santos 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from gce-cr-linux-08 (425.31 KB, application/zip)
2012-07-02 06:06 PDT, WebKit Review Bot 		no flags
Details
Patch (2.83 KB, patch)
2012-07-02 11:47 PDT, Thiago Marcos P. Santos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Thiago Marcos P. Santos
Comment 1 2012-07-02 05:25:46 PDT
Created attachment 150402 [details] Patch
WebKit Review Bot
Comment 2 2012-07-02 06:06:49 PDT
Comment on attachment 150402 [details] Patch Attachment 150402 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13125164 New failing tests: fast/loader/loadInProgress.html
WebKit Review Bot
Comment 3 2012-07-02 06:06:53 PDT
Created attachment 150409 [details] Archive of layout-test-results from gce-cr-linux-08 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-08 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
jochen
Comment 4 2012-07-02 07:03:56 PDT
Adam, something's fishy with the new cr-linux-ews bots
Adam Barth
Comment 5 2012-07-02 09:11:18 PDT
(In reply to comment #4) > Adam, something's fishy with the new cr-linux-ews bots Thanks. /me will investigate.
Adam Barth
Comment 6 2012-07-02 09:32:05 PDT
Yes. Turns out that test is very flaky on the bot. I've marked it as flaky, which should silence it for now.
Daniel Bates
Comment 7 2012-07-02 11:40:47 PDT
Comment on attachment 150402 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150402&action=review OK. > Source/WebKit/ChangeLog:3 > + [EFL][CMake] Integrate API utests with CTest Nit: utests => unit tests > ChangeLog:3 > + [EFL][CMake] Integrate API utests with CTest Ditto.
Thiago Marcos P. Santos
Comment 8 2012-07-02 11:47:26 PDT
Created attachment 150457 [details] Patch
WebKit Review Bot
Comment 9 2012-07-02 12:46:36 PDT
Comment on attachment 150457 [details] Patch Clearing flags on attachment: 150457 Committed r121702: <http://trac.webkit.org/changeset/121702>
WebKit Review Bot
Comment 10 2012-07-02 12:46:43 PDT
All reviewed patches have been landed. Closing bug.
Thiago Marcos P. Santos
Comment 11 2012-07-03 09:21:57 PDT
*** Bug 68511 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.