Bug 87204

Summary:

[V8] Pass Isolate to v8::Null() in bindings/v8/*.{h,cpp}

Product:

WebKit

Reporter:

Kentaro Hara <haraken>

Component:

WebCore JavaScript

Assignee:

Kentaro Hara <haraken>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

abarth, dglazkov, japhet, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

84074

Attachments:

Description	Flags
Patch	abarth: review+, webkit.review.bot: commit-queue-
Archive of layout-test-results from ec2-cr-linux-04	none
patch for landing	webkit.review.bot: commit-queue-
Archive of layout-test-results from ec2-cq-03	none

Kentaro Hara

Reported 2012-05-22 21:22:03 PDT

The objective is to pass Isolate around in V8 bindings. In this bug we pass Isolate to v8::Null() in bindings/v8/*.{h,cpp}.

Attachments
Patch (5.98 KB, patch) 2012-05-22 21:23 PDT, Kentaro Hara	abarth: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cr-linux-04 (598.20 KB, application/zip) 2012-05-22 23:10 PDT, WebKit Review Bot	no flags	Details
patch for landing (5.51 KB, patch) 2012-05-22 23:39 PDT, Kentaro Hara	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cq-03 (553.26 KB, application/zip) 2012-05-23 02:14 PDT, WebKit Review Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Kentaro Hara

Comment 1 2012-05-22 21:23:37 PDT

Created attachment 143451 [details] Patch

Build Bot

Comment 2 2012-05-22 21:46:20 PDT

Comment on attachment 143451 [details] Patch Attachment 143451 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12767146

Adam Barth

Comment 3 2012-05-22 22:49:36 PDT

Comment on attachment 143451 [details] Patch I wonder why the win bot went red. None of this code should be linked into win. Please watch the bot when landing to make sure this patch doesn't cause a problem.

Adam Barth

Comment 4 2012-05-22 23:03:01 PDT

WebKitSupportLibrary.zip is out-of-date. ^^ The win-ews error doesn't look like your fault.

Kentaro Hara

Comment 5 2012-05-22 23:04:14 PDT

(In reply to comment #4) > WebKitSupportLibrary.zip is out-of-date. > > ^^ The win-ews error doesn't look like your fault. Yeah, I hope commit-queue will land the patch.

WebKit Review Bot

Comment 6 2012-05-22 23:10:02 PDT

Comment on attachment 143451 [details] Patch Attachment 143451 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12770115 New failing tests: fast/dom/StyleSheet/css-medialist-item.html webintents/web-intents-api.html storage/indexeddb/keypath-edges.html fast/dom/HTMLElement/class-list.html storage/indexeddb/database-basics.html fast/dom/HTMLElement/class-list-quirks.html storage/indexeddb/objectstore-basics-workers.html storage/indexeddb/objectstore-basics.html svg/css/svg-attribute-parser-mode.html storage/indexeddb/index-basics.html fast/dom/HTMLOutputElement/dom-settable-token-list.html storage/indexeddb/index-basics-workers.html

WebKit Review Bot

Comment 7 2012-05-22 23:10:06 PDT

Created attachment 143469 [details] Archive of layout-test-results from ec2-cr-linux-04 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-04 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Kentaro Hara

Comment 8 2012-05-22 23:39:38 PDT

Created attachment 143475 [details] patch for landing

WebKit Review Bot

Comment 9 2012-05-23 02:14:28 PDT

Comment on attachment 143475 [details] patch for landing Rejecting attachment 143475 [details] from commit-queue. New failing tests: webintents/web-intents-api.html storage/indexeddb/keypath-edges.html storage/indexeddb/objectstore-basics-workers.html storage/indexeddb/objectstore-basics.html storage/indexeddb/index-basics.html storage/indexeddb/index-basics-workers.html Full output: http://queues.webkit.org/results/12767211

WebKit Review Bot

Comment 10 2012-05-23 02:14:33 PDT

Created attachment 143506 [details] Archive of layout-test-results from ec2-cq-03 The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: ec2-cq-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Note You need to log in before you can comment on or make changes to this bug.