Bug 87099
| Summary: | REGRESSION(r117815): It made fast/css/zoom-in-length-round-trip.html fail on !ENABLE(SUBPIXEL_LAYOUT) platforms | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Szilard Ledan <szledan> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | eae, eric, kling, leviw, mrobinson, ossy, pnormand, tmpsantos |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 79666, 85555 | ||
Szilard Ledan
These tests fail in Qt, GTK and Mac bots.
--- /ramdisk/qt-linux-64-release/build/layout-test-results/css1/units/rounding-expected.txt
+++ /ramdisk/qt-linux-64-release/build/layout-test-results/css1/units/rounding-actual.txt
@@ -4,8 +4,8 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-FAIL divtop.bottom should be 31. Was 29.
-PASS divbottom.top is 31
+FAIL Math.round(divtop.bottom) should be 31. Was 29.
+PASS Math.round(divbottom.top) is 31
PASS successfullyParsed is true
TEST COMPLETE
--- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/css/zoom-in-length-round-trip-expected.txt
+++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/css/zoom-in-length-round-trip-actual.txt
@@ -2,5 +2,24 @@
The test queries offsetWidth and offsetHeight of a 1Ă10-pixel rectangle under zooming by a factor of k/100 for 100 ⤠k ⤠200.
-PASS
+FAIL at 106% magnification: 1 mapped to 1 and 10 mapped to 10.
+FAIL at 107% magnification: 1 mapped to 1 and 10 mapped to 10.
+FAIL at 108% magnification: 1 mapped to 1 and 10 mapped to 10.
+FAIL at 109% magnification: 1 mapped to 1 and 10 mapped to 10.
+FAIL at 116% magnification: 1 mapped to 1 and 10 mapped to 10.
+FAIL at 117% magnification: 1 mapped to 1 and 10 mapped to 10.
+FAIL at 118% magnification: 1 mapped to 1 and 10 mapped to 10.
+FAIL at 119% magnification: 1 mapped to 1 and 10 mapped to 10.
+FAIL at 127% magnification: 1 mapped to 1 and 10 mapped to 10.
+FAIL at 128% magnification: 1 mapped to 1 and 10 mapped to 10.
+FAIL at 129% magnification: 1 mapped to 1 and 10 mapped to 10.
+FAIL at 137% magnification: 1 mapped to 1 and 10 mapped to 10.
+FAIL at 138% magnification: 1 mapped to 1 and 10 mapped to 10.
+FAIL at 139% magnification: 1 mapped to 1 and 10 mapped to 10.
+FAIL at 148% magnification: 1 mapped to 1 and 10 mapped to 10.
+FAIL at 149% magnification: 1 mapped to 1 and 10 mapped to 10.
+FAIL at 158% magnification: 1 mapped to 1 and 10 mapped to 10.
+FAIL at 159% magnification: 1 mapped to 1 and 10 mapped to 10.
+FAIL at 169% magnification: 1 mapped to 1 and 10 mapped to 10.
+FAIL at 179% magnification: 1 mapped to 1 and 10 mapped to 10.
Could you check it, please?
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Emil A Eklund
The first one (css1/units/rounding-actual) just needs to be rebaselined. The second one is more interesting, I'll look into it tomorrow.
Szilard Ledan
Thank you for your comment; you're right, the first one only needs to be rebased.
Both of them have been skipped in
http://trac.webkit.org/changeset/117936/trunk/LayoutTests/platform/qt/Skipped
The first one (css1/units/rounding.html) have been unskipped and rebased here:
http://trac.webkit.org/changeset/117939.
Please unskip the second one (fast/css/zoom-in-length-round-trip.html) after it has been fixed.
Emil A Eklund
Will do, thank you.
Thiago Marcos P. Santos
I'm also adding fast/css/zoom-in-length-round-trip.html to EFL test_expectations.txt. Please remember to remove from there too.
Levi Weintraub
*** This bug has been marked as a duplicate of bug 87145 ***
Levi Weintraub
Unskipped in r118013: <http://trac.webkit.org/changeset/118013>
Csaba Osztrogonác
Unskipped on Qt too - r118135.