Bug 87042

Summary: Incorporate new tex-image-and-sub-image-2d-with-video*.html tests
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, feature-media-reviews, fischman, kbr, webkit.review.bot, zmo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 86877    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Kenneth Russell
Reported 2012-05-21 13:41:28 PDT
In Bug 86877 several variants of fast/canvas/webgl/tex-image-and-sub-image-2d-with-*.html are being incorporated which verify uploading of DOM elements and ImageData to packed texture formats. Unfortunately, upgrading tex-image-and-sub-image-2d-with-video.html is proving difficult because of an assertion failure seen in Chromium, filed as https://code.google.com/p/chromium/issues/detail?id=129041 . (I am not sure why this isn't being seen on any of the bots -- it doesn't have any entries in Chromium's test_expectations.txt.) For the moment this test is being left as is. The assertion failure should be tracked down and fixed, and once it is, the updated tests integrated.
Attachments
Patch (19.59 KB, patch)
2012-05-24 18:49 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ami Fischman
Comment 1 2012-05-21 13:45:21 PDT
Chromium-side fix is in the CQ: https://chromiumcodereview.appspot.com/10332275/
Kenneth Russell
Comment 2 2012-05-21 14:42:51 PDT
With that fix in place, the refactored tests still fail to run properly. The failure mode is strange; it looks like the presence of the video tag on the page is causing the onload handler to fail to run before the LayoutTestController decides whether it should exit early or wait until done. Will put up a patch for these tests after fixing Bug 86877 so we can investigate whether there is a bug in event dispatching related to the video tag.
Kenneth Russell
Comment 3 2012-05-24 17:58:24 PDT
There was no bug in the video tag. The test was just pointing to nonexistent resources so the "playing" event was never dispatched. Integrating the new tests now.
Kenneth Russell
Comment 4 2012-05-24 18:15:00 PDT
Actually, I take that back. There is something weird going on. These tests were calling layoutTestController.waitUntilDone() inside the onload handler, but when that is done, they intermittently exit early. Instead it's necessary to call waitUntilDone() in script that's executed while the page is being loaded. I think that is a bug and will file it separately.
Kenneth Russell
Comment 5 2012-05-24 18:43:03 PDT
Bug 87448 filed about race condition with video tag.
Kenneth Russell
Comment 6 2012-05-24 18:49:06 PDT
Created attachment 143947 [details] Patch
James Robinson
Comment 7 2012-05-25 14:04:33 PDT
Comment on attachment 143947 [details] Patch Looks good.
WebKit Review Bot
Comment 8 2012-05-25 14:38:25 PDT
Comment on attachment 143947 [details] Patch Clearing flags on attachment: 143947 Committed r118565: <http://trac.webkit.org/changeset/118565>
WebKit Review Bot
Comment 9 2012-05-25 14:38:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.