Bug 86831

Summary: [V8] Remove V8Proxy::notHandledByInterceptor()
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 85330    
Attachments:
Description Flags
Patch
abarth: review+, webkit.review.bot: commit-queue-
patch for landing none

Kentaro Hara
Reported 2012-05-18 02:20:59 PDT
As per the discussion in https://bugs.webkit.org/show_bug.cgi?id=85330, we replace 'return V8Proxy::notHandledByInterceptor()' with 'return v8::Handle<v8::Value>()'.
Attachments
Patch (35.79 KB, patch)
2012-05-18 02:26 PDT, Kentaro Hara 		abarth: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
patch for landing (35.77 KB, patch)
2012-05-20 17:24 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-05-18 02:26:18 PDT
Created attachment 142672 [details] Patch
Adam Barth
Comment 2 2012-05-18 04:43:08 PDT
Comment on attachment 142672 [details] Patch Death to the cargo cult.
WebKit Review Bot
Comment 3 2012-05-18 05:33:44 PDT
Comment on attachment 142672 [details] Patch Rejecting attachment 142672 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 11551 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 47>At revision 11551. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/12721795
Adam Barth
Comment 4 2012-05-18 05:47:57 PDT
Sorry for the bad error messages: Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ I think this hit a merge conflict at the very end of the commit cycle.
Kentaro Hara
Comment 5 2012-05-20 17:24:39 PDT
Created attachment 142929 [details] patch for landing
WebKit Review Bot
Comment 6 2012-05-21 19:30:29 PDT
Comment on attachment 142929 [details] patch for landing Clearing flags on attachment: 142929 Committed r117873: <http://trac.webkit.org/changeset/117873>
Adam Barth
Comment 7 2012-08-03 09:54:10 PDT
Looks like this landed a while ago.
Note You need to log in before you can comment on or make changes to this bug.