Bug 86086
| Summary: | [Qt][WK2] REGRESSION(r116560): It made 7 compositing tests fail | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | enne, jamesr, noam, ossy, yael |
| Priority: | P2 | Keywords: | Qt, QtTriaged |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 79666, 85820 | ||
Csaba Osztrogonác
Before http://trac.webkit.org/changeset/116560 compositing tests pass on Qt5-WK2 platform.
But this change modified only the expected files without any source change. So after
this change the tests started to fail on Qt: http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release%20WebKit2%20%28Amazon%20EC2%29/r116562%20%282497%29/results.html
I don't know anything about these tests, numbers in the expected files
don't say for me anything, I have no idea which one is the correct. And
I can't compare png results, because they are set to dumpastext, and
generating pixel result for dumpastext tests is impossible.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Csaba Osztrogonác
I skipped them - http://trac.webkit.org/changeset/116628
Noam Rosenthal
Thanks, it's ok to skip those for now, I'll take a look.
Adrienne Walker
(In reply to comment #0)
> But this change modified only the expected files without any source change.
You're right that there was no source change, but I modified the tests and then updated the expectations to match those test changes.
If it helps, I suspect that it was the addition of margin:0 and the removal of overflow:hidden that moved things around in your text expectations.