Bug 85877
| Summary: | [EFL][DRT] Intrusive Theming overrides collide with style-related LayoutTests | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Dominik Röttsches (drott) <d-r> |
| Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | antognolli+webkit, barbieri, glima, gyuyoung.kim, ky0.choi, leandro, lucas.de.marchi, mcatanzaro, rakuco, sw0524.lee |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 85494, 91952 | ||
| Bug Blocks: | 85484, 85497, 85603 | ||
Dominik Röttsches (drott)
RenderThemeEfl.cpp aggresively overrides style on certain elements in the ::adjust* methods, for example:
::adjustTextFieldStyle() overrides:
adjustSizeConstraints(style, TextField);
style->resetBorder();
style->setWhiteSpace(PRE);
style->setColor(m_entryTextForegroundColor);
style->setBackgroundColor(m_entryTextBackgroundColor);
This causes bug 85497, bug 85603, bug 85484.
I think we should less aggressively override the styles with theming here and make these cases pass instead. Feedback welcome.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Gustavo Sverzut Barbieri
Totally agreed.
When we first wrote RenderThemeEfl.cpp we based it on Gtk and Qt, not really something we desired to have, very likely similar to what was in these other ports at the time.
KwangYong Choi
For the information,
fast/forms/menulist-narrow-width.html
fast/forms/select-baseline.html
fast/forms/menulist-style-color.html
fast/forms/select-style.html
These tests seem to have similar style error.
Michael Catanzaro
Closing this bug because the EFL port has been removed from trunk.
If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.