Bug 85820

Summary: Update compositing/RTL tests to fail if the root layer is shifted incorrectly
Product: WebKit Reporter: Adrienne Walker <enne>
Component: New BugsAssignee: Adrienne Walker <enne>
Status: RESOLVED FIXED    
Severity: Normal CC: enne, jamesr, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 86086    
Bug Blocks: 85672    
Attachments:
Description Flags
Patch none

Adrienne Walker
Reported 2012-05-07 13:22:42 PDT
Update compositing/RTL tests to fail if the root layer is shifted incorrectly
Attachments
Patch (27.87 KB, patch)
2012-05-07 13:27 PDT, Adrienne Walker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrienne Walker
Comment 1 2012-05-07 13:27:08 PDT
Created attachment 140577 [details] Patch
Adrienne Walker
Comment 2 2012-05-07 14:13:51 PDT
I guess I wasn't clear on how I fixed it, so here's a better change description: I set margin:0 on all tests, set the background to red, and then added a big white layer over top of the entire root layer. If the root layer is incorrectly shifted in the compositor, then it won't cover the red background and the test will fail. This will probably only fail on Chromium, because we logically end up doing a clear with the root background color.
James Robinson
Comment 3 2012-05-09 14:45:59 PDT
Comment on attachment 140577 [details] Patch R=me
WebKit Review Bot
Comment 4 2012-05-09 15:00:25 PDT
Comment on attachment 140577 [details] Patch Clearing flags on attachment: 140577 Committed r116560: <http://trac.webkit.org/changeset/116560>
WebKit Review Bot
Comment 5 2012-05-09 15:00:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.