Bug 85796

Summary: MediaStream API: Rename MediaStreamCenter::didConstructMediaStream
Product: WebKit Reporter: Tommy Widenflycht <tommyw>
Component: DOMAssignee: Tommy Widenflycht <tommyw>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric.carlson, feature-media-reviews, fishd, gustavo, jamesr, tkent+wkapi, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 56459    
Attachments:
Description Flags
Patch
none
Patch none

Tommy Widenflycht
Reported 2012-05-07 06:02:37 PDT
Renamed MediaStreamCenter::didConstructMediaStream to didCreateMediaStream, and change so that it is only called for MediaStreams created from JS. Also in the chromium embedder send out the WebMediaStreamDescriptor non-const instead.
Attachments
Patch (7.39 KB, patch)
2012-05-07 06:16 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Patch (9.32 KB, patch)
2012-05-07 06:36 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tommy Widenflycht
Comment 1 2012-05-07 06:16:05 PDT
Created attachment 140516 [details] Patch
WebKit Review Bot
Comment 2 2012-05-07 06:18:51 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Gustavo Noronha (kov)
Comment 3 2012-05-07 06:21:39 PDT
Comment on attachment 140516 [details] Patch Attachment 140516 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12644155
Tommy Widenflycht
Comment 4 2012-05-07 06:36:19 PDT
Created attachment 140521 [details] Patch
WebKit Review Bot
Comment 5 2012-05-07 10:55:49 PDT
Comment on attachment 140521 [details] Patch Clearing flags on attachment: 140521 Committed r116321: <http://trac.webkit.org/changeset/116321>
WebKit Review Bot
Comment 6 2012-05-07 10:55:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.