Bug 85627

Summary: Tie lifetime of SVGAnimateElement::m_animatedType to the duration of the animation
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 41761    
Attachments:
Description Flags
Patch koivisto: review+

Nikolas Zimmermann
Reported 2012-05-04 08:13:49 PDT
Tie lifetime of SVGAnimateElement::m_animatedType to the duration of the animation. For non-frozen animations, we still keep the animVal around and just reset it to the base val. For CSS property animations we never remove a property if we animated it via SMIL, but only change it back to the base value. This makes integration with CSS Animations/Transitions hard, and needs to be changed both for CSS & XML animations. Unfortunately that requires a precise knowledge of which animation is contributing to an animated value at any point in time. Patch upcoming.
Attachments
Patch (38.19 KB, patch)
2012-05-04 08:20 PDT, Nikolas Zimmermann 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2012-05-04 08:20:01 PDT
Created attachment 140236 [details] Patch
Antti Koivisto
Comment 2 2012-05-08 11:53:18 PDT
Comment on attachment 140236 [details] Patch r=me
Nikolas Zimmermann
Comment 3 2012-05-08 12:43:43 PDT
Committed r116451: <http://trac.webkit.org/changeset/116451>
Note You need to log in before you can comment on or make changes to this bug.